<p>pespin <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-pcu/+/26167">View Change</a></p><div style="white-space:pre-wrap">Approvals:
laforge: Looks good to me, but someone else must approve
fixeria: Looks good to me, approved
Jenkins Builder: Verified
</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">tests/alloc: Extend test_bts_pch_timer() to validate MI type TMSI<br><br>Change-Id: I3673d387fa735b54fbc137ffaa18af581fa1b85a<br>---<br>M tests/alloc/AllocTest.cpp<br>M tests/alloc/AllocTest.err<br>2 files changed, 8 insertions(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/tests/alloc/AllocTest.cpp b/tests/alloc/AllocTest.cpp</span><br><span>index cd9c7bc..1f2bbda 100644</span><br><span>--- a/tests/alloc/AllocTest.cpp</span><br><span>+++ b/tests/alloc/AllocTest.cpp</span><br><span>@@ -807,9 +807,12 @@</span><br><span> {</span><br><span> struct gprs_rlcmac_bts *bts = bts_alloc(the_pcu, 0);</span><br><span> struct osmo_mobile_identity mi_imsi1, mi_imsi2;</span><br><span style="color: hsl(120, 100%, 40%);">+ struct osmo_mobile_identity mi_tmsi1;</span><br><span> mi_imsi1.type = mi_imsi2.type = GSM_MI_TYPE_IMSI;</span><br><span style="color: hsl(120, 100%, 40%);">+ mi_tmsi1.type = GSM_MI_TYPE_TMSI;</span><br><span> OSMO_STRLCPY_ARRAY(mi_imsi1.imsi, "1234");</span><br><span> OSMO_STRLCPY_ARRAY(mi_imsi2.imsi, "5678");</span><br><span style="color: hsl(120, 100%, 40%);">+ mi_tmsi1.tmsi = 987654321;</span><br><span> </span><br><span> fprintf(stderr, "Testing bts_pch_timer dealloc on bts dealloc\n");</span><br><span> log_set_category_filter(osmo_stderr_target, DPCU, 1, LOGL_DEBUG);</span><br><span>@@ -817,6 +820,8 @@</span><br><span> fprintf(stderr, "Starting PCH timer for 2 IMSI\n");</span><br><span> bts_pch_timer_start(bts, &mi_imsi1, mi_imsi1.imsi);</span><br><span> bts_pch_timer_start(bts, &mi_imsi2, mi_imsi2.imsi);</span><br><span style="color: hsl(120, 100%, 40%);">+ fprintf(stderr, "Starting PCH timer for 1 TMSI\n");</span><br><span style="color: hsl(120, 100%, 40%);">+ bts_pch_timer_start(bts, &mi_tmsi1, "6666");</span><br><span> </span><br><span> fprintf(stderr, "Deallocating BTS, expecting the PCH timer to be stopped and deallocated\n");</span><br><span> talloc_free(bts);</span><br><span>diff --git a/tests/alloc/AllocTest.err b/tests/alloc/AllocTest.err</span><br><span>index 53e2edd..1f86336 100644</span><br><span>--- a/tests/alloc/AllocTest.err</span><br><span>+++ b/tests/alloc/AllocTest.err</span><br><span>@@ -501221,6 +501221,9 @@</span><br><span> Starting PCH timer for 2 IMSI</span><br><span> PCH paging timer started for MI=IMSI-1234 IMSI=1234</span><br><span> PCH paging timer started for MI=IMSI-5678 IMSI=5678</span><br><span style="color: hsl(120, 100%, 40%);">+Starting PCH timer for 1 TMSI</span><br><span style="color: hsl(120, 100%, 40%);">+PCH paging timer started for MI=TMSI-0x3ADE68B1 IMSI=6666</span><br><span> Deallocating BTS, expecting the PCH timer to be stopped and deallocated</span><br><span> PCH paging timer stopped for IMSI=1234</span><br><span> PCH paging timer stopped for IMSI=5678</span><br><span style="color: hsl(120, 100%, 40%);">+PCH paging timer stopped for IMSI=6666</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-pcu/+/26167">change 26167</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-pcu/+/26167"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: osmo-pcu </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I3673d387fa735b54fbc137ffaa18af581fa1b85a </div>
<div style="display:none"> Gerrit-Change-Number: 26167 </div>
<div style="display:none"> Gerrit-PatchSet: 4 </div>
<div style="display:none"> Gerrit-Owner: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>