<p>pespin <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-pcu/+/26156">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  fixeria: Looks good to me, but someone else must approve
  neels: Looks good to me, approved
  Jenkins Builder: Verified

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">tbf: Mark initial first_(common_)ts with special value<br><br>This way it's easier to distinguish when this value was not properly<br>filled when debugging or looking at logs.<br><br>Change-Id: I0c9c9fdcfca9eb15125ea49efcbb76711850052e<br>---<br>M src/tbf.cpp<br>M src/tbf.h<br>2 files changed, 6 insertions(+), 6 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/tbf.cpp b/src/tbf.cpp</span><br><span>index 4bd87dd..bdba2e7 100644</span><br><span>--- a/src/tbf.cpp</span><br><span>+++ b/src/tbf.cpp</span><br><span>@@ -94,9 +94,9 @@</span><br><span> gprs_rlcmac_tbf::gprs_rlcmac_tbf(struct gprs_rlcmac_bts *bts_, GprsMs *ms, gprs_rlcmac_tbf_direction dir) :</span><br><span>        direction(dir),</span><br><span>      trx(NULL),</span><br><span style="color: hsl(0, 100%, 40%);">-      first_ts(0),</span><br><span style="color: hsl(0, 100%, 40%);">-    first_common_ts(0),</span><br><span style="color: hsl(0, 100%, 40%);">-     control_ts(TBF_CONTROL_TS_UNSET),</span><br><span style="color: hsl(120, 100%, 40%);">+     first_ts(TBF_TS_UNSET),</span><br><span style="color: hsl(120, 100%, 40%);">+       first_common_ts(TBF_TS_UNSET),</span><br><span style="color: hsl(120, 100%, 40%);">+        control_ts(TBF_TS_UNSET),</span><br><span>    fT(0),</span><br><span>       num_fT_exp(0),</span><br><span>       upgrade_to_multislot(false),</span><br><span>@@ -251,7 +251,7 @@</span><br><span>    * confirmation from the MS and goes through the FLOW state. Hence, we</span><br><span>        * may have ULC pollings ongoing and we need to make sure we drop all</span><br><span>         * reserved nodes there: */</span><br><span style="color: hsl(0, 100%, 40%);">-     if (tbf->control_ts != TBF_CONTROL_TS_UNSET && !tbf->pdch[tbf->control_ts])</span><br><span style="color: hsl(120, 100%, 40%);">+  if (tbf->control_ts != TBF_TS_UNSET && !tbf->pdch[tbf->control_ts])</span><br><span>                 pdch_ulc_release_tbf(tbf->trx->pdch[tbf->control_ts].ulc, tbf);</span><br><span> </span><br><span>         /* Now simply detach from all attached PDCHs */</span><br><span>@@ -340,7 +340,7 @@</span><br><span> </span><br><span> void tbf_assign_control_ts(struct gprs_rlcmac_tbf *tbf)</span><br><span> {</span><br><span style="color: hsl(0, 100%, 40%);">-       if (tbf->control_ts == TBF_CONTROL_TS_UNSET)</span><br><span style="color: hsl(120, 100%, 40%);">+       if (tbf->control_ts == TBF_TS_UNSET)</span><br><span>              LOGPTBF(tbf, LOGL_INFO, "Setting Control TS %d\n",</span><br><span>                         tbf->first_common_ts);</span><br><span>    else if (tbf->control_ts != tbf->first_common_ts)</span><br><span>diff --git a/src/tbf.h b/src/tbf.h</span><br><span>index 4013ab0..4652d95 100644</span><br><span>--- a/src/tbf.h</span><br><span>+++ b/src/tbf.h</span><br><span>@@ -116,7 +116,7 @@</span><br><span> #define GPRS_RLCMAC_FLAG_TO_DL_ACK    3 /* DL TBF: Failed to receive last polled DL ACK/NACK */</span><br><span> #define GPRS_RLCMAC_FLAG_TO_MASK   0xf0 /* timeout bits */</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-#define TBF_CONTROL_TS_UNSET 0xff</span><br><span style="color: hsl(120, 100%, 40%);">+#define TBF_TS_UNSET 0xff</span><br><span> </span><br><span> #define T_START(tbf, t, T, r, f) tbf->t_start(t, T, r, f, __FILE__, __LINE__)</span><br><span> </span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-pcu/+/26156">change 26156</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-pcu/+/26156"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-pcu </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I0c9c9fdcfca9eb15125ea49efcbb76711850052e </div>
<div style="display:none"> Gerrit-Change-Number: 26156 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: neels <nhofmeyr@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>