<p>fixeria has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmo-bsc/+/26144">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">abis_rsl: permit simultaneous ACCH repetition and overpower<br><br>As stated in "GSM/EDGE Evolution and Performance", section 12.3,<br>both features *can* be enabled simultaneously.<br><br>Change-Id: I2189f01bd78625dab3d642597240338ee581fc98<br>Related: SYS#5319<br>---<br>M src/osmo-bsc/abis_rsl.c<br>1 file changed, 3 insertions(+), 18 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/44/26144/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/osmo-bsc/abis_rsl.c b/src/osmo-bsc/abis_rsl.c</span><br><span>index cdd57c2..75c0bd7 100644</span><br><span>--- a/src/osmo-bsc/abis_rsl.c</span><br><span>+++ b/src/osmo-bsc/abis_rsl.c</span><br><span>@@ -555,30 +555,15 @@</span><br><span> /* indicate Temporary overpower of SACCH and FACCH channels */</span><br><span> static void top_acch_cap_for_bts(struct gsm_lchan *lchan, struct msgb *msg)</span><br><span> {</span><br><span style="color: hsl(0, 100%, 40%);">-        struct abis_rsl_osmo_temp_ovp_acch_cap cap;</span><br><span>  struct gsm_bts *bts = lchan->ts->trx->bts;</span><br><span style="color: hsl(0, 100%, 40%);">-     bool acch_rep_enabled;</span><br><span style="color: hsl(0, 100%, 40%);">-  bool acch_rep_supp_by_ms;</span><br><span> </span><br><span>        /* The BTS_FEAT_ACCH_TEMP_OVP IE is a proprietary IE, that can only be used with osmo-bts type BTSs */</span><br><span>       if (!(bts->model->type == GSM_BTS_TYPE_OSMOBTS && osmo_bts_has_feature(&bts->features, BTS_FEAT_ACCH_TEMP_OVP)))</span><br><span>                return;</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-     memcpy(&cap, &bts->temporary_overpower, sizeof(cap));</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">-        /* The user has enabled one of the two downlink related ACCH repetition features. */</span><br><span style="color: hsl(0, 100%, 40%);">-    acch_rep_enabled = bts->repeated_acch_policy.dl_sacch || bts->repeated_acch_policy.dl_facch_all</span><br><span style="color: hsl(0, 100%, 40%);">-       || bts->repeated_acch_policy.dl_facch_cmd;</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">-       /* The MS indicates support for ACCH repetition */</span><br><span style="color: hsl(0, 100%, 40%);">-      acch_rep_supp_by_ms = lchan->conn && lchan->conn->cm3_valid && lchan->conn->cm3.repeated_acch_capability;</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">-        /* If the MS fully supports repeated ACCH capabilites as specified in 3GPP TS 44.006, section 10 and 11. and if</span><br><span style="color: hsl(0, 100%, 40%);">-  * ACCH repetition is enabled for this BTS, then we will not apply temporary overpower. */</span><br><span style="color: hsl(0, 100%, 40%);">-      if (acch_rep_enabled && acch_rep_supp_by_ms)</span><br><span style="color: hsl(0, 100%, 40%);">-            cap.overpower_db = 0;</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">-   msgb_tlv_put(msg, RSL_IE_OSMO_TEMP_OVP_ACCH_CAP, sizeof(cap), (uint8_t*) &cap);</span><br><span style="color: hsl(120, 100%, 40%);">+   msgb_tlv_put(msg, RSL_IE_OSMO_TEMP_OVP_ACCH_CAP,</span><br><span style="color: hsl(120, 100%, 40%);">+                   sizeof(bts->temporary_overpower),</span><br><span style="color: hsl(120, 100%, 40%);">+                  (void *)&bts->temporary_overpower);</span><br><span> }</span><br><span> </span><br><span> /* Write RSL_IE_OSMO_TRAINING_SEQUENCE to msgb. The tsc_set argument's range is 1-4, tsc argument range is 0-7. */</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-bsc/+/26144">change 26144</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-bsc/+/26144"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-bsc </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I2189f01bd78625dab3d642597240338ee581fc98 </div>
<div style="display:none"> Gerrit-Change-Number: 26144 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: fixeria <vyanitskiy@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>