<p>fixeria has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/pysim/+/26124">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">Python is not C: get rid of unnecessary semicolons<br><br>See https://www.python.org/dev/peps/pep-0008/.<br><br>Change-Id: I9de3bcd324b0a1b98af761678996eaae85f7f790<br>Related: OS#5292<br>---<br>M pySim-shell.py<br>M pySim/utils.py<br>2 files changed, 7 insertions(+), 7 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/24/26124/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/pySim-shell.py b/pySim-shell.py</span><br><span>index 3fc5859..0be6f21 100755</span><br><span>--- a/pySim-shell.py</span><br><span>+++ b/pySim-shell.py</span><br><span>@@ -72,15 +72,15 @@</span><br><span>            sl.wait_for_card(3)</span><br><span>  except NoCardError:</span><br><span>          print("No card detected!")</span><br><span style="color: hsl(0, 100%, 40%);">-            return None, None;</span><br><span style="color: hsl(120, 100%, 40%);">+            return None, None</span><br><span>    except:</span><br><span>              print("Card not readable!")</span><br><span style="color: hsl(0, 100%, 40%);">-           return None, None;</span><br><span style="color: hsl(120, 100%, 40%);">+            return None, None</span><br><span> </span><br><span>        card = card_detect("auto", scc)</span><br><span>    if card is None:</span><br><span>             print("Could not detect card type!")</span><br><span style="color: hsl(0, 100%, 40%);">-          return None, None;</span><br><span style="color: hsl(120, 100%, 40%);">+            return None, None</span><br><span> </span><br><span>        # Create runtime state with card profile</span><br><span>     profile = CardProfileUICC()</span><br><span>@@ -207,7 +207,7 @@</span><br><span>    @cmd2.with_category(CUSTOM_CATEGORY)</span><br><span>         def do_equip(self, opts):</span><br><span>            """Equip pySim-shell with card"""</span><br><span style="color: hsl(0, 100%, 40%);">-         rs, card = init_card(sl);</span><br><span style="color: hsl(120, 100%, 40%);">+             rs, card = init_card(sl)</span><br><span>             self.equip(card, rs)</span><br><span> </span><br><span>     class InterceptStderr(list):</span><br><span>@@ -352,7 +352,7 @@</span><br><span>                   except (KeyboardInterrupt):</span><br><span>                          self.poutput("")</span><br><span>                           self.poutput("Terminated by user!")</span><br><span style="color: hsl(0, 100%, 40%);">-                           return;</span><br><span style="color: hsl(120, 100%, 40%);">+                               return</span><br><span>                       except (SystemExit):</span><br><span>                                 # When all cards are processed the card handler device will throw a SystemExit</span><br><span>                               # exception. Also Errors that are not recoverable (cards stuck etc.) will end up here.</span><br><span>diff --git a/pySim/utils.py b/pySim/utils.py</span><br><span>index def88f0..68de14a 100644</span><br><span>--- a/pySim/utils.py</span><br><span>+++ b/pySim/utils.py</span><br><span>@@ -133,7 +133,7 @@</span><br><span>     compr = tag.get('comprehension', False)</span><br><span>     if tag['tag'] in [0x00, 0x80, 0xff] or tag['tag'] > 0xff:</span><br><span>         # 3-byte format</span><br><span style="color: hsl(0, 100%, 40%);">-        byte3 = tag['tag'] & 0xff;</span><br><span style="color: hsl(120, 100%, 40%);">+        byte3 = tag['tag'] & 0xff</span><br><span>         byte2 = (tag['tag'] >> 8) & 0x7f</span><br><span>         if compr:</span><br><span>             byte2 |= 0x80</span><br><span>@@ -243,7 +243,7 @@</span><br><span>         t |= (cls & 3) << 6</span><br><span>         return bytes([t])</span><br><span>     else: # multi-byte tag</span><br><span style="color: hsl(0, 100%, 40%);">-        t = 0x1f;</span><br><span style="color: hsl(120, 100%, 40%);">+        t = 0x1f</span><br><span>         if constructed:</span><br><span>             t |= 0x20</span><br><span>         t |= (cls & 3) << 6</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/pysim/+/26124">change 26124</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/pysim/+/26124"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: pysim </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I9de3bcd324b0a1b98af761678996eaae85f7f790 </div>
<div style="display:none"> Gerrit-Change-Number: 26124 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: fixeria <vyanitskiy@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>