<p>laforge <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-sgsn/+/26098">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Jenkins Builder: Verified
  pespin: Looks good to me, but someone else must approve
  laforge: Looks good to me, approved

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">Revert "Turn some compiler warnings into errors"<br><br>Do not turn some compiler warnings into errors by default. This patch<br>was added before --enable-werror was available.<br><br>We build with --enable-werror during development and in CI. If the code<br>is built with a different compiler that throws additional warnings, it<br>should not stop the build.<br><br>This reverts commit 34f012639ddf41470714ae74ae961d158670a4c7.<br><br>Related: OS#5289<br>Change-Id: I24e0a0d7f93f196dc642e37b03f68464024c09d4<br>---<br>M configure.ac<br>1 file changed, 0 insertions(+), 12 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/configure.ac b/configure.ac</span><br><span>index c29bacb..9607373 100644</span><br><span>--- a/configure.ac</span><br><span>+++ b/configure.ac</span><br><span>@@ -34,11 +34,6 @@</span><br><span> fi</span><br><span> PKG_PROG_PKG_CONFIG([0.20])</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-dnl check for AX_CHECK_COMPILE_FLAG</span><br><span style="color: hsl(0, 100%, 40%);">-m4_ifdef([AX_CHECK_COMPILE_FLAG], [], [</span><br><span style="color: hsl(0, 100%, 40%);">-     AC_MSG_ERROR([Please install autoconf-archive; re-run 'autoreconf -fi' for it to take effect.])</span><br><span style="color: hsl(0, 100%, 40%);">- ])</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span> dnl use a defined standard across all builds and don't depend on compiler default</span><br><span> CFLAGS="$CFLAGS -std=gnu11"</span><br><span> </span><br><span>@@ -124,13 +119,6 @@</span><br><span> CPPFLAGS="$CPPFLAGS -Wall -Wno-trigraphs"</span><br><span> CFLAGS="$CFLAGS -Wall -Wno-trigraphs"</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-AX_CHECK_COMPILE_FLAG([-Werror=implicit], [CFLAGS="$CFLAGS -Werror=implicit"])</span><br><span style="color: hsl(0, 100%, 40%);">-AX_CHECK_COMPILE_FLAG([-Werror=maybe-uninitialized], [CFLAGS="$CFLAGS -Werror=maybe-uninitialized"])</span><br><span style="color: hsl(0, 100%, 40%);">-AX_CHECK_COMPILE_FLAG([-Werror=memset-transposed-args], [CFLAGS="$CFLAGS -Werror=memset-transposed-args"])</span><br><span style="color: hsl(0, 100%, 40%);">-AX_CHECK_COMPILE_FLAG([-Wnull-dereference], [CFLAGS="$CFLAGS -Wnull-dereference"])</span><br><span style="color: hsl(0, 100%, 40%);">-AX_CHECK_COMPILE_FLAG([-Werror=sizeof-array-argument], [CFLAGS="$CFLAGS -Werror=sizeof-array-argument"])</span><br><span style="color: hsl(0, 100%, 40%);">-AX_CHECK_COMPILE_FLAG([-Werror=sizeof-pointer-memaccess], [CFLAGS="$CFLAGS -Werror=sizeof-pointer-memaccess"])</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span> # Coverage build taken from WebKit's configure.in</span><br><span> AC_MSG_CHECKING([whether to enable code coverage support])</span><br><span> AC_ARG_ENABLE(coverage,</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-sgsn/+/26098">change 26098</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-sgsn/+/26098"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-sgsn </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I24e0a0d7f93f196dc642e37b03f68464024c09d4 </div>
<div style="display:none"> Gerrit-Change-Number: 26098 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: osmith <osmith@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>