<p>pespin has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmo-bts/+/26088">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">bts-trx: sched_lchan_tchf: Drop impossible code path<br><br>It cannot happen that msg1 is NULL and msg2 is not null, since they are<br>deuqueed from same place. Only possible combinations are:<br>msg1!=NULL && msg2!=NULL<br>msg1!=NULL && msg2==NULL<br><br>Change-Id: Ifd789844b1a7dfba596664de440d4c20b9f4c78f<br>---<br>M src/osmo-bts-trx/sched_lchan_tchf.c<br>1 file changed, 0 insertions(+), 6 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/88/26088/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/osmo-bts-trx/sched_lchan_tchf.c b/src/osmo-bts-trx/sched_lchan_tchf.c</span><br><span>index 20a4077..a6fcd7a 100644</span><br><span>--- a/src/osmo-bts-trx/sched_lchan_tchf.c</span><br><span>+++ b/src/osmo-bts-trx/sched_lchan_tchf.c</span><br><span>@@ -398,12 +398,6 @@</span><br><span>                                        msg_tch = msg2;</span><br><span>                      }</span><br><span>            }</span><br><span style="color: hsl(0, 100%, 40%);">-       } else if (msg2) {</span><br><span style="color: hsl(0, 100%, 40%);">-              l1sap = msgb_l1sap_prim(msg2);</span><br><span style="color: hsl(0, 100%, 40%);">-          if (l1sap->oph.primitive == PRIM_TCH)</span><br><span style="color: hsl(0, 100%, 40%);">-                        msg_tch = msg2;</span><br><span style="color: hsl(0, 100%, 40%);">-         else</span><br><span style="color: hsl(0, 100%, 40%);">-                    msg_facch = msg2;</span><br><span>    }</span><br><span> </span><br><span>        /* check validity of message */</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-bts/+/26088">change 26088</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-bts/+/26088"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-bts </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Ifd789844b1a7dfba596664de440d4c20b9f4c78f </div>
<div style="display:none"> Gerrit-Change-Number: 26088 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>