<p>neels has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmo-bsc/+/26069">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">drop unused gsm48_tx_mm_serv_ack()<br><br>Related: SYS#4878<br>Change-Id: Ia9d841a8243adca347e7ea79d31e3cd65eab27ea<br>---<br>M include/osmocom/bsc/gsm_04_08_rr.h<br>M src/osmo-bsc/gsm_08_08.c<br>2 files changed, 0 insertions(+), 20 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/69/26069/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/include/osmocom/bsc/gsm_04_08_rr.h b/include/osmocom/bsc/gsm_04_08_rr.h</span><br><span>index 5ddee7f..1f50ef9 100644</span><br><span>--- a/include/osmocom/bsc/gsm_04_08_rr.h</span><br><span>+++ b/include/osmocom/bsc/gsm_04_08_rr.h</span><br><span>@@ -33,9 +33,6 @@</span><br><span> int gsm48_lchan_modify(struct gsm_lchan *lchan, uint8_t mode);</span><br><span> int gsm48_rx_rr_modif_ack(struct msgb *msg);</span><br><span> int gsm48_parse_meas_rep(struct gsm_meas_rep *rep, struct msgb *msg);</span><br><span style="color: hsl(0, 100%, 40%);">-int gsm48_tx_mm_serv_ack(struct gsm_subscriber_connection *conn);</span><br><span style="color: hsl(0, 100%, 40%);">-int gsm48_tx_mm_serv_rej(struct gsm_subscriber_connection *conn,</span><br><span style="color: hsl(0, 100%, 40%);">-                    enum gsm48_reject_value value);</span><br><span> </span><br><span> struct msgb *gsm48_create_mm_serv_rej(enum gsm48_reject_value value);</span><br><span> struct msgb *gsm48_create_loc_upd_rej(uint8_t cause);</span><br><span>diff --git a/src/osmo-bsc/gsm_08_08.c b/src/osmo-bsc/gsm_08_08.c</span><br><span>index 91c90fe..1715533 100644</span><br><span>--- a/src/osmo-bsc/gsm_08_08.c</span><br><span>+++ b/src/osmo-bsc/gsm_08_08.c</span><br><span>@@ -101,23 +101,6 @@</span><br><span>           msgb_free(resp);</span><br><span> }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-/* 9.2.5 CM service accept */</span><br><span style="color: hsl(0, 100%, 40%);">-int gsm48_tx_mm_serv_ack(struct gsm_subscriber_connection *conn)</span><br><span style="color: hsl(0, 100%, 40%);">-{</span><br><span style="color: hsl(0, 100%, 40%);">- struct msgb *msg = gsm48_msgb_alloc_name("GSM 04.08 SERV ACK");</span><br><span style="color: hsl(0, 100%, 40%);">-       struct gsm48_hdr *gh = (struct gsm48_hdr *) msgb_put(msg, sizeof(*gh));</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">- msg->lchan = conn->lchan;</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">- gh->proto_discr = GSM48_PDISC_MM;</span><br><span style="color: hsl(0, 100%, 40%);">-    gh->msg_type = GSM48_MT_MM_CM_SERV_ACC;</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">-      DEBUGP(DMM, "-> CM SERVICE ACK\n");</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">-        gscon_submit_rsl_dtap(conn, msg, 0, 0);</span><br><span style="color: hsl(0, 100%, 40%);">- return 0;</span><br><span style="color: hsl(0, 100%, 40%);">-}</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span> static bool is_cm_service_for_emerg(struct msgb *msg)</span><br><span> {</span><br><span>     struct gsm48_service_request *cm;</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-bsc/+/26069">change 26069</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-bsc/+/26069"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-bsc </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Ia9d841a8243adca347e7ea79d31e3cd65eab27ea </div>
<div style="display:none"> Gerrit-Change-Number: 26069 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: neels <nhofmeyr@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>