<p>neels has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmo-bsc/+/26071">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">tweak intra-bsc ho counter descriptions<br><br>Related: SYS#4878<br>Change-Id: I00eaf42fcd705cf3f4e06e8c7434fd05dbad4b84<br>---<br>M src/osmo-bsc/bsc_stats.c<br>M src/osmo-bsc/bts.c<br>2 files changed, 10 insertions(+), 10 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/71/26071/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/osmo-bsc/bsc_stats.c b/src/osmo-bsc/bsc_stats.c</span><br><span>index 7176809..ccba4a6 100644</span><br><span>--- a/src/osmo-bsc/bsc_stats.c</span><br><span>+++ b/src/osmo-bsc/bsc_stats.c</span><br><span>@@ -35,13 +35,13 @@</span><br><span>    [BSC_CTR_ASSIGNMENT_FAILED] =           {"assignment:failed", "Received Assignment Failure message"},</span><br><span>    [BSC_CTR_ASSIGNMENT_ERROR] =            {"assignment:error", "Assignment failed for other reason"},</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-     [BSC_CTR_HANDOVER_ATTEMPTED] =          {"handover:attempted", "Intra-BSC handover attempts"},</span><br><span style="color: hsl(0, 100%, 40%);">-      [BSC_CTR_HANDOVER_COMPLETED] =          {"handover:completed", "Intra-BSC handover completed"},</span><br><span style="color: hsl(120, 100%, 40%);">+   [BSC_CTR_HANDOVER_ATTEMPTED] =          {"handover:attempted", "Handover attempts"},</span><br><span style="color: hsl(120, 100%, 40%);">+      [BSC_CTR_HANDOVER_COMPLETED] =          {"handover:completed", "Handover completed"},</span><br><span>    [BSC_CTR_HANDOVER_STOPPED] =            {"handover:stopped", "Connection ended during HO"},</span><br><span>      [BSC_CTR_HANDOVER_NO_CHANNEL] =         {"handover:no_channel", "Failure to allocate lchan for HO"},</span><br><span>     [BSC_CTR_HANDOVER_TIMEOUT] =            {"handover:timeout", "Handover timed out"},</span><br><span>      [BSC_CTR_HANDOVER_FAILED] =             {"handover:failed", "Received Handover Fail messages"},</span><br><span style="color: hsl(0, 100%, 40%);">-     [BSC_CTR_HANDOVER_ERROR] =              {"handover:error", "Re-assignment failed for other reason"},</span><br><span style="color: hsl(120, 100%, 40%);">+      [BSC_CTR_HANDOVER_ERROR] =              {"handover:error", "Handover failed for other reason"},</span><br><span> </span><br><span>      [BSC_CTR_INTRA_CELL_HO_ATTEMPTED] =     {"intra_cell_ho:attempted", "Intra-Cell handover attempts"},</span><br><span>     [BSC_CTR_INTRA_CELL_HO_COMPLETED] =     {"intra_cell_ho:completed", "Intra-Cell handover completed"},</span><br><span>@@ -49,15 +49,15 @@</span><br><span>      [BSC_CTR_INTRA_CELL_HO_NO_CHANNEL] =    {"intra_cell_ho:no_channel", "Failure to allocate lchan for HO"},</span><br><span>        [BSC_CTR_INTRA_CELL_HO_TIMEOUT] =       {"intra_cell_ho:timeout", "Handover timed out"},</span><br><span>         [BSC_CTR_INTRA_CELL_HO_FAILED] =        {"intra_cell_ho:failed", "Received Handover Fail messages"},</span><br><span style="color: hsl(0, 100%, 40%);">-        [BSC_CTR_INTRA_CELL_HO_ERROR] = {"intra_cell_ho:error", "Re-assignment failed for other reason"},</span><br><span style="color: hsl(120, 100%, 40%);">+ [BSC_CTR_INTRA_CELL_HO_ERROR] = {"intra_cell_ho:error", "Intra-cell handover failed for other reason"},</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- [BSC_CTR_INTRA_BSC_HO_ATTEMPTED] =      {"intra_bsc_ho:attempted", "Intra-BSC handover attempts"},</span><br><span style="color: hsl(0, 100%, 40%);">-  [BSC_CTR_INTRA_BSC_HO_COMPLETED] =      {"intra_bsc_ho:completed", "Intra-BSC handover completed"},</span><br><span style="color: hsl(120, 100%, 40%);">+       [BSC_CTR_INTRA_BSC_HO_ATTEMPTED] =      {"intra_bsc_ho:attempted", "Intra-BSC inter-cell handover attempts"},</span><br><span style="color: hsl(120, 100%, 40%);">+     [BSC_CTR_INTRA_BSC_HO_COMPLETED] =      {"intra_bsc_ho:completed", "Intra-BSC inter-cell handover completed"},</span><br><span>   [BSC_CTR_INTRA_BSC_HO_STOPPED] =        {"intra_bsc_ho:stopped", "Connection ended during HO"},</span><br><span>  [BSC_CTR_INTRA_BSC_HO_NO_CHANNEL] =     {"intra_bsc_ho:no_channel", "Failure to allocate lchan for HO"},</span><br><span>         [BSC_CTR_INTRA_BSC_HO_TIMEOUT] =        {"intra_bsc_ho:timeout", "Handover timed out"},</span><br><span>  [BSC_CTR_INTRA_BSC_HO_FAILED] =         {"intra_bsc_ho:failed", "Received Handover Fail messages"},</span><br><span style="color: hsl(0, 100%, 40%);">- [BSC_CTR_INTRA_BSC_HO_ERROR] =          {"intra_bsc_ho:error", "Re-assignment failed for other reason"},</span><br><span style="color: hsl(120, 100%, 40%);">+  [BSC_CTR_INTRA_BSC_HO_ERROR] =          {"intra_bsc_ho:error", "Intra-BSC inter-cell HO failed for other reason"},</span><br><span> </span><br><span>   [BSC_CTR_INTER_BSC_HO_OUT_ATTEMPTED] =  {"interbsc_ho_out:attempted",</span><br><span>                                               "Attempts to handover to remote BSS"},</span><br><span>diff --git a/src/osmo-bsc/bts.c b/src/osmo-bsc/bts.c</span><br><span>index 28059bb..ee2e791 100644</span><br><span>--- a/src/osmo-bsc/bts.c</span><br><span>+++ b/src/osmo-bsc/bts.c</span><br><span>@@ -1146,10 +1146,10 @@</span><br><span> </span><br><span>         [BTS_CTR_INTRA_BSC_HO_ATTEMPTED] = \</span><br><span>                 { "intra_bsc_ho:attempted",</span><br><span style="color: hsl(0, 100%, 40%);">-             "Intra-BSC handover attempts" },</span><br><span style="color: hsl(120, 100%, 40%);">+            "Intra-BSC inter-cell handover attempts" },</span><br><span>      [BTS_CTR_INTRA_BSC_HO_COMPLETED] = \</span><br><span>                 { "intra_bsc_ho:completed",</span><br><span style="color: hsl(0, 100%, 40%);">-             "Intra-BSC handover completed" },</span><br><span style="color: hsl(120, 100%, 40%);">+           "Intra-BSC inter-cell handover completed" },</span><br><span>     [BTS_CTR_INTRA_BSC_HO_STOPPED] = \</span><br><span>           { "intra_bsc_ho:stopped",</span><br><span>            "Connection ended during HO" },</span><br><span>@@ -1164,7 +1164,7 @@</span><br><span>            "Received Handover Fail messages" },</span><br><span>     [BTS_CTR_INTRA_BSC_HO_ERROR] = \</span><br><span>             { "intra_bsc_ho:error",</span><br><span style="color: hsl(0, 100%, 40%);">-                 "Re-assignment failed for other reason" },</span><br><span style="color: hsl(120, 100%, 40%);">+                  "Intra-BSC inter-cell HO failed for other reason" },</span><br><span> </span><br><span>         [BTS_CTR_INTER_BSC_HO_OUT_ATTEMPTED] = \</span><br><span>             { "interbsc_ho_out:attempted",</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-bsc/+/26071">change 26071</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-bsc/+/26071"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-bsc </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I00eaf42fcd705cf3f4e06e8c7434fd05dbad4b84 </div>
<div style="display:none"> Gerrit-Change-Number: 26071 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: neels <nhofmeyr@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>