<p>pespin <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-hnodeb/+/26023">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Jenkins Builder: Verified
  laforge: Looks good to me, approved
  fixeria: Looks good to me, but someone else must approve

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">Generate proper rnc_id and plmn in LuRequest<br><br>Change-Id: Ib40b5eb96b7cc13c424076a4ca725019514d52af<br>---<br>M include/osmocom/hnodeb/ranap.h<br>M src/osmo-hnodeb/ranap.c<br>M src/osmo-hnodeb/vty.c<br>3 files changed, 6 insertions(+), 5 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/include/osmocom/hnodeb/ranap.h b/include/osmocom/hnodeb/ranap.h</span><br><span>index df756b1..7864c69 100644</span><br><span>--- a/include/osmocom/hnodeb/ranap.h</span><br><span>+++ b/include/osmocom/hnodeb/ranap.h</span><br><span>@@ -30,4 +30,4 @@</span><br><span> void hnb_rua_dt_handle_ranap(struct hnb *hnb, struct ranap_message_s *ranap_msg);</span><br><span> void hnb_rua_cl_handle_ranap(struct hnb *hnb, struct ranap_message_s *ranap_msg);</span><br><span> void hnb_tx_iu_release_req(struct hnb *hnb);</span><br><span style="color: hsl(0, 100%, 40%);">-struct msgb *gen_initue_lu(int is_ps, uint32_t conn_id, const char *imsi);</span><br><span style="color: hsl(120, 100%, 40%);">+struct msgb *gen_initue_lu(const struct hnb *hnb, int is_ps, uint32_t conn_id, const char *imsi);</span><br><span>diff --git a/src/osmo-hnodeb/ranap.c b/src/osmo-hnodeb/ranap.c</span><br><span>index fae87b7..3dd759f 100644</span><br><span>--- a/src/osmo-hnodeb/ranap.c</span><br><span>+++ b/src/osmo-hnodeb/ranap.c</span><br><span>@@ -110,16 +110,17 @@</span><br><span>  }</span><br><span> }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-struct msgb *gen_initue_lu(int is_ps, uint32_t conn_id, const char *imsi)</span><br><span style="color: hsl(120, 100%, 40%);">+struct msgb *gen_initue_lu(const struct hnb *hnb, int is_ps, uint32_t conn_id, const char *imsi)</span><br><span> {</span><br><span>   uint8_t lu[] = { GSM48_PDISC_MM, GSM48_MT_MM_LOC_UPD_REQUEST,</span><br><span>                         0x70, 0x62, 0xf2, 0x30, 0xff, 0xf3, 0x57,</span><br><span>           /*       len, IMSI/type, IMSI-------------------------------- */</span><br><span>                      0x08, 0x29, 0x26, 0x24, 0x10, 0x32, 0x54, 0x76, 0x98,</span><br><span>                        0x33, 0x03, 0x57, 0x18 , 0xb2 };</span><br><span style="color: hsl(0, 100%, 40%);">-       uint8_t plmn_id[] = { 0x09, 0x01, 0x99 };</span><br><span style="color: hsl(120, 100%, 40%);">+     uint8_t plmn_id[3];</span><br><span style="color: hsl(120, 100%, 40%);">+   osmo_plmn_to_bcd(plmn_id, &hnb->plmn);</span><br><span>        RANAP_GlobalRNC_ID_t rnc_id = {</span><br><span style="color: hsl(0, 100%, 40%);">-         .rNC_ID = 23,</span><br><span style="color: hsl(120, 100%, 40%);">+         .rNC_ID = g_hnb->rnc_id,</span><br><span>          .pLMNidentity.buf = plmn_id,</span><br><span>                 .pLMNidentity.size = sizeof(plmn_id),</span><br><span>        };</span><br><span>diff --git a/src/osmo-hnodeb/vty.c b/src/osmo-hnodeb/vty.c</span><br><span>index 714e00d..61a3f4c 100644</span><br><span>--- a/src/osmo-hnodeb/vty.c</span><br><span>+++ b/src/osmo-hnodeb/vty.c</span><br><span>@@ -354,7 +354,7 @@</span><br><span>    chan->conn_id = conn_id;</span><br><span>  conn_id++;</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-  msg = gen_initue_lu(chan->is_ps, chan->conn_id, chan->imsi);</span><br><span style="color: hsl(120, 100%, 40%);">+ msg = gen_initue_lu(g_hnb, chan->is_ps, chan->conn_id, chan->imsi);</span><br><span>         rua = rua_new_conn(chan->is_ps, chan->conn_id, msg);</span><br><span> </span><br><span>       hnb_iuh_send(g_hnb, rua);</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-hnodeb/+/26023">change 26023</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-hnodeb/+/26023"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-hnodeb </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Ib40b5eb96b7cc13c424076a4ca725019514d52af </div>
<div style="display:none"> Gerrit-Change-Number: 26023 </div>
<div style="display:none"> Gerrit-PatchSet: 3 </div>
<div style="display:none"> Gerrit-Owner: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>