<p>pespin <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-iuh/+/26031">View Change</a></p><div style="white-space:pre-wrap">Approvals:
fixeria: Looks good to me, but someone else must approve
osmith: Looks good to me, approved
Jenkins Builder: Verified
</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">hnb-test: Fix memleak in hnb_read_cb<br><br>Change-Id: I6ecbce6aab11e1382ff9f71d901e1c6ac145f835<br>---<br>M src/tests/hnb-test.c<br>1 file changed, 6 insertions(+), 5 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/tests/hnb-test.c b/src/tests/hnb-test.c</span><br><span>index 02af4d9..2c73fed 100644</span><br><span>--- a/src/tests/hnb-test.c</span><br><span>+++ b/src/tests/hnb-test.c</span><br><span>@@ -583,22 +583,22 @@</span><br><span> /* FIXME: clean up after disappeared HNB */</span><br><span> close(fd->fd);</span><br><span> osmo_fd_unregister(fd);</span><br><span style="color: hsl(0, 100%, 40%);">- return rc;</span><br><span style="color: hsl(120, 100%, 40%);">+ goto free_ret;</span><br><span> } else if (rc == 0) {</span><br><span> LOGP(DMAIN, LOGL_INFO, "Connection to HNB closed\n");</span><br><span> close(fd->fd);</span><br><span> osmo_fd_unregister(fd);</span><br><span> fd->fd = -1;</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">- return -1;</span><br><span style="color: hsl(120, 100%, 40%);">+ rc = -1;</span><br><span style="color: hsl(120, 100%, 40%);">+ goto free_ret;</span><br><span> } else {</span><br><span> msgb_put(msg, rc);</span><br><span> }</span><br><span> </span><br><span> if (flags & MSG_NOTIFICATION) {</span><br><span> LOGP(DMAIN, LOGL_DEBUG, "Ignoring SCTP notification\n");</span><br><span style="color: hsl(0, 100%, 40%);">- msgb_free(msg);</span><br><span style="color: hsl(0, 100%, 40%);">- return 0;</span><br><span style="color: hsl(120, 100%, 40%);">+ rc = 0;</span><br><span style="color: hsl(120, 100%, 40%);">+ goto free_ret;</span><br><span> }</span><br><span> </span><br><span> sinfo.sinfo_ppid = ntohl(sinfo.sinfo_ppid);</span><br><span>@@ -626,6 +626,7 @@</span><br><span> break;</span><br><span> }</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+free_ret:</span><br><span> msgb_free(msg);</span><br><span> return rc;</span><br><span> }</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-iuh/+/26031">change 26031</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-iuh/+/26031"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: osmo-iuh </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I6ecbce6aab11e1382ff9f71d901e1c6ac145f835 </div>
<div style="display:none"> Gerrit-Change-Number: 26031 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: daniel <dwillmann@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: dexter <pmaier@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: neels <nhofmeyr@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: osmith <osmith@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>