<p><a href="https://gerrit.osmocom.org/c/osmo-msc/+/25982">View Change</a></p><p>3 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/c/osmo-msc/+/25982/7/include/osmocom/msc/mncc.h">File include/osmocom/msc/mncc.h:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/osmo-msc/+/25982/7/include/osmocom/msc/mncc.h@166">Patch Set #7, Line 166:</a> <code style="font-family:monospace,monospace">     uint8_t         gcr[16];</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">looks like we want a header file in libosmocore for 29.205 with some LEN define for 16?</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/c/osmo-msc/+/25982/7/src/libmsc/gsm_04_08_cc.c">File src/libmsc/gsm_04_08_cc.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/osmo-msc/+/25982/7/src/libmsc/gsm_04_08_cc.c@529">Patch Set #7, Line 529:</a> <code style="font-family:monospace,monospace">              if (msg != NULL && (rc = osmo_enc_gcr(gcr_msg, gcr)) > 0) {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">why should msg be null?</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/osmo-msc/+/25982/7/src/libmsc/gsm_04_08_cc.c@530">Patch Set #7, Line 530:</a> <code style="font-family:monospace,monospace">                   memcpy(&setup.gcr[0], gcr_msg->data, rc);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">why this double copy? simply pass &setup.gcr[0] to osmo_enc_gcr</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-msc/+/25982">change 25982</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-msc/+/25982"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-msc </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I259b6d7e4cbe26159b9b496356fc7c1c27d54521 </div>
<div style="display:none"> Gerrit-Change-Number: 25982 </div>
<div style="display:none"> Gerrit-PatchSet: 7 </div>
<div style="display:none"> Gerrit-Owner: fixeria <vyanitskiy@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: keith <keith@rhizomatica.org> </div>
<div style="display:none"> Gerrit-CC: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-Comment-Date: Tue, 02 Nov 2021 17:59:11 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: No </div>
<div style="display:none"> Gerrit-MessageType: comment </div>