<p>Patch set 2:<span style="border-radius: 3px; display: inline-block; margin: 0 2px; padding: 4px;background-color: #d4ffd4;">Code-Review +1</span></p><p><a href="https://gerrit.osmocom.org/c/pysim/+/26055">View Change</a></p><p>2 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/c/pysim/+/26055/2/pySim/commands.py">File pySim/commands.py:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/pysim/+/26055/2/pySim/commands.py@148">Patch Set #2, Line 148:</a> <code style="font-family:monospace,monospace">                       data, sw = self._tp.send_apdu_checksw(pdu)</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">I would wrap this block into additional try/catch:</p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">  try:<br>    data, sw = self._tp.send_apdu_checksw(pdu)<br>    total_data += data<br>    chunk_offset += chunk_len<br>  except Exception as e:<br>    raise ValueError('Failed to read (offset %d)' % (offset)) from e</pre><p style="white-space: pre-wrap; word-wrap: break-word;">Note 'from e' in the last line. This way, if send_apdu_checksw() raises an exception, it would get equipped with the contextual information. See https://docs.python.org/3/tutorial/errors.html#exception-chaining.</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/pysim/+/26055/2/pySim/commands.py@177">Patch Set #2, Line 177:</a> <code style="font-family:monospace,monospace">                  chunk_data, chunk_sw = self._tp.send_apdu_checksw(pdu)</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Same here.</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.osmocom.org/c/pysim/+/26055">change 26055</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/pysim/+/26055"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: pysim </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I9ce556ac0b7bb21c5c5a27170c32af0152255b79 </div>
<div style="display:none"> Gerrit-Change-Number: 26055 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: dexter <pmaier@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: daniel <dwillmann@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Comment-Date: Mon, 01 Nov 2021 18:29:59 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: Yes </div>
<div style="display:none"> Gerrit-MessageType: comment </div>