<p>fixeria has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmo-bts/+/26051">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">measurement: get rid of *le in lchan_meas_handle_sacch()<br><br>The current Timing Advance value can be obtained either from the<br>L1 SACCH header (if received) or from lchan->ta_ctrl.current.<br><br>Change-Id: I2b3693a0e49f03f2b4496c9dbd30cf47e9bc86b5<br>---<br>M src/common/measurement.c<br>1 file changed, 3 insertions(+), 6 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/51/26051/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/common/measurement.c b/src/common/measurement.c</span><br><span>index e4d950e..94df965 100644</span><br><span>--- a/src/common/measurement.c</span><br><span>+++ b/src/common/measurement.c</span><br><span>@@ -782,9 +782,9 @@</span><br><span>       lchan->meas.last_fn = LCHAN_FN_DUMMY;</span><br><span> }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-static inline uint8_t ms_to2rsl(const struct gsm_lchan *lchan, const struct lapdm_entity *le)</span><br><span style="color: hsl(120, 100%, 40%);">+static inline uint8_t ms_to2rsl(const struct gsm_lchan *lchan, uint8_t ta)</span><br><span> {</span><br><span style="color: hsl(0, 100%, 40%);">- return (lchan->ms_t_offs >= 0) ? lchan->ms_t_offs : (lchan->p_offs - le->ta);</span><br><span style="color: hsl(120, 100%, 40%);">+  return (lchan->ms_t_offs >= 0) ? lchan->ms_t_offs : (lchan->p_offs - ta);</span><br><span> }</span><br><span> </span><br><span> static inline bool ms_to_valid(const struct gsm_lchan *lchan)</span><br><span>@@ -898,7 +898,6 @@</span><br><span>        const struct gsm48_meas_res *mr = NULL;</span><br><span>      const struct gsm48_hdr *gh = NULL;</span><br><span>   int timing_offset, rc;</span><br><span style="color: hsl(0, 100%, 40%);">-  struct lapdm_entity *le;</span><br><span>     bool dtxu_used;</span><br><span>      uint8_t ms_pwr;</span><br><span>      uint8_t ms_ta;</span><br><span>@@ -932,9 +931,7 @@</span><br><span>                 ms_ta = lchan->ta_ctrl.current;</span><br><span>   }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-   le = &lchan->lapdm_ch.lapdm_acch;</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">-        timing_offset = ms_to_valid(lchan) ? ms_to2rsl(lchan, le) : -1;</span><br><span style="color: hsl(120, 100%, 40%);">+       timing_offset = ms_to_valid(lchan) ? ms_to2rsl(lchan, ms_ta) : -1;</span><br><span>   rc = rsl_tx_meas_res(lchan, msgb_l3(msg), msgb_l3len(msg), timing_offset);</span><br><span>   if (rc == 0) /* Count successful transmissions */</span><br><span>            lchan->meas.res_nr++;</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-bts/+/26051">change 26051</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-bts/+/26051"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-bts </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I2b3693a0e49f03f2b4496c9dbd30cf47e9bc86b5 </div>
<div style="display:none"> Gerrit-Change-Number: 26051 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: fixeria <vyanitskiy@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>