<p>laforge <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-pcu/+/26033">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  pespin: Looks good to me, but someone else must approve
  fixeria: Looks good to me, but someone else must approve
  laforge: Looks good to me, approved
  Jenkins Builder: Verified

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">gprs_bssgp_pcu: Fix crash when configuring an existing ns bind<br><br>ns_configure_nse() only sets bind when it doesn't exist yet. If it<br>already exists bind[i] stays NULL and causes a segfault in<br>gprs_ns2_is_ip_bind() later on.<br>This patch ensures bind[i] is either created of set to the existing<br>bind.<br><br>Change-Id: I103e82e6c64324c087a4ff325a83eeab0e5a4ee9<br>Related: SYS#4971<br>---<br>M src/gprs_bssgp_pcu.c<br>1 file changed, 2 insertions(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/gprs_bssgp_pcu.c b/src/gprs_bssgp_pcu.c</span><br><span>index 1fcacdb..0dd6cdc 100644</span><br><span>--- a/src/gprs_bssgp_pcu.c</span><br><span>+++ b/src/gprs_bssgp_pcu.c</span><br><span>@@ -1118,7 +1118,8 @@</span><br><span>              if (!(valid & (1 << i)))</span><br><span>                   continue;</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-           if (!gprs_ns2_ip_bind_by_sockaddr(the_pcu->nsi, &local[i])) {</span><br><span style="color: hsl(120, 100%, 40%);">+          bind[i] = gprs_ns2_ip_bind_by_sockaddr(the_pcu->nsi, &local[i]);</span><br><span style="color: hsl(120, 100%, 40%);">+               if (!bind[i]) {</span><br><span>                      snprintf(name, sizeof(name), "pcu%u", i);</span><br><span>                  rc = gprs_ns2_ip_bind(the_pcu->nsi, name, &local[i], 0, &bind[i]);</span><br><span>                        if (rc < 0) {</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-pcu/+/26033">change 26033</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-pcu/+/26033"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-pcu </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I103e82e6c64324c087a4ff325a83eeab0e5a4ee9 </div>
<div style="display:none"> Gerrit-Change-Number: 26033 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: daniel <dwillmann@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: dexter <pmaier@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: lynxis lazus <lynxis@fe80.eu> </div>
<div style="display:none"> Gerrit-Reviewer: neels <nhofmeyr@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>