<p>laforge <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-msc/+/25930">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Jenkins Builder: Verified
  laforge: Looks good to me, approved

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">smpp_smsc: use osmo_talloc_replace_string() in smpp_smsc_conf()<br><br>Change-Id: Ie3dc0d9673a0410a5908cba77fc352d581bac6f6<br>Fixes: CID#240711<br>---<br>M src/libmsc/smpp_smsc.c<br>1 file changed, 1 insertion(+), 7 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/libmsc/smpp_smsc.c b/src/libmsc/smpp_smsc.c</span><br><span>index a5c6165..4581865 100644</span><br><span>--- a/src/libmsc/smpp_smsc.c</span><br><span>+++ b/src/libmsc/smpp_smsc.c</span><br><span>@@ -987,14 +987,8 @@</span><br><span>       /* Avoid use-after-free if bind_addr == smsc->bind_addr */</span><br><span>        if (smsc->bind_addr == bind_addr)</span><br><span>                 return 0;</span><br><span style="color: hsl(120, 100%, 40%);">+     osmo_talloc_replace_string(smsc, &smsc->bind_addr, bind_addr);</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-       talloc_free((void*)smsc->bind_addr);</span><br><span style="color: hsl(0, 100%, 40%);">- smsc->bind_addr = NULL;</span><br><span style="color: hsl(0, 100%, 40%);">-      if (bind_addr) {</span><br><span style="color: hsl(0, 100%, 40%);">-                smsc->bind_addr = bind_addr ? talloc_strdup(smsc, bind_addr) : NULL;</span><br><span style="color: hsl(0, 100%, 40%);">-         if (!smsc->bind_addr)</span><br><span style="color: hsl(0, 100%, 40%);">-                        return -ENOMEM;</span><br><span style="color: hsl(0, 100%, 40%);">- }</span><br><span>    return 0;</span><br><span> }</span><br><span> </span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-msc/+/25930">change 25930</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-msc/+/25930"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-msc </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Ie3dc0d9673a0410a5908cba77fc352d581bac6f6 </div>
<div style="display:none"> Gerrit-Change-Number: 25930 </div>
<div style="display:none"> Gerrit-PatchSet: 4 </div>
<div style="display:none"> Gerrit-Owner: fixeria <vyanitskiy@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: osmith <osmith@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>