<p>laforge <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-gbproxy/+/26036">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Jenkins Builder: Verified
  pespin: Looks good to me, but someone else must approve
  laforge: Looks good to me, approved

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">gbproxy: Route STATUS in PtP-BVC by TLLI/TMSI as well<br><br>Related: SYS#5235, OS#4892<br>Change-Id: Ib31c60ba840522719f307df089efeb8f4da1d9ae<br>---<br>M src/gb_proxy.c<br>1 file changed, 21 insertions(+), 3 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/gb_proxy.c b/src/gb_proxy.c</span><br><span>index 18e0efb..7333e80 100644</span><br><span>--- a/src/gb_proxy.c</span><br><span>+++ b/src/gb_proxy.c</span><br><span>@@ -380,6 +380,8 @@</span><br><span>       return gbprox_relay2peer(msg, sgsn_bvc, sig_bvci ? 0 : sgsn_bvc->bvci);</span><br><span> }</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+static int gbproxy_tlli_from_status_pdu(struct tlv_parsed *tp, uint32_t *tlli, char *log_pfx);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> /* Receive an incoming PTP message from a BSS-side NS-VC */</span><br><span> static int gbprox_rx_ptp_from_bss(struct gbproxy_nse *nse, struct msgb *msg, uint16_t ns_bvci)</span><br><span> {</span><br><span>@@ -496,12 +498,28 @@</span><br><span>          osmo_fsm_inst_dispatch(bss_bvc->fi, BSSGP_BVCFSM_E_RX_FC_BVC, msg);</span><br><span>               break;</span><br><span>       case BSSGP_PDUT_STATUS:</span><br><span style="color: hsl(0, 100%, 40%);">-         /* TODO: Implement by inspecting the contained PDU */</span><br><span style="color: hsl(0, 100%, 40%);">-           if (!TLVP_PRESENT(&tp, BSSGP_IE_PDU_IN_ERROR))</span><br><span style="color: hsl(120, 100%, 40%);">+    {</span><br><span style="color: hsl(120, 100%, 40%);">+             struct gbproxy_sgsn *sgsn;</span><br><span style="color: hsl(120, 100%, 40%);">+            /* Check if the status needs to be terminated locally */</span><br><span style="color: hsl(120, 100%, 40%);">+              uint8_t cause = *TLVP_VAL(&tp, BSSGP_IE_CAUSE);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+         LOGPNSE(nse, LOGL_NOTICE, "Rx STATUS cause=0x%02x(%s)\n", cause,</span><br><span style="color: hsl(120, 100%, 40%);">+                    bssgp_cause_str(cause));</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+            if (gbproxy_tlli_from_status_pdu(&tp, &tlli, log_pfx) == 0)</span><br><span style="color: hsl(120, 100%, 40%);">+                   sgsn = gbproxy_select_sgsn(nse->cfg, &tlli);</span><br><span style="color: hsl(120, 100%, 40%);">+           else</span><br><span style="color: hsl(120, 100%, 40%);">+                  sgsn = gbproxy_select_sgsn(nse->cfg, NULL);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+              if (!sgsn) {</span><br><span style="color: hsl(120, 100%, 40%);">+                  rc = -EINVAL;</span><br><span>                        break;</span><br><span style="color: hsl(0, 100%, 40%);">-          LOGPBVC(bss_bvc, LOGL_ERROR, "Rx %s: Implementation missing\n", pdut_name);</span><br><span style="color: hsl(120, 100%, 40%);">+         }</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+           rc = gbprox_relay2nse(msg, sgsn->nse, ns_bvci);</span><br><span>           break;</span><br><span>       }</span><br><span style="color: hsl(120, 100%, 40%);">+     }</span><br><span> </span><br><span>        return 0;</span><br><span> }</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-gbproxy/+/26036">change 26036</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-gbproxy/+/26036"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-gbproxy </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Ib31c60ba840522719f307df089efeb8f4da1d9ae </div>
<div style="display:none"> Gerrit-Change-Number: 26036 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: daniel <dwillmann@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: lynxis lazus <lynxis@fe80.eu> </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>