<p>fixeria has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmo-bts/+/26048">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">measurement: pass *mr to repeated_dl_facch_active_decision()<br><br>Change-Id: Idbf5f95d632aa2270c49b351ad5561ca2182bf9a<br>---<br>M src/common/measurement.c<br>1 file changed, 3 insertions(+), 10 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/48/26048/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/common/measurement.c b/src/common/measurement.c</span><br><span>index 124e6e5..b25104e 100644</span><br><span>--- a/src/common/measurement.c</span><br><span>+++ b/src/common/measurement.c</span><br><span>@@ -795,9 +795,8 @@</span><br><span> /* Decide if repeated FACCH should be applied or not. If RXQUAL level, that the</span><br><span>  * MS reports is high enough, FACCH repetition is not needed. */</span><br><span> static void repeated_dl_facch_active_decision(struct gsm_lchan *lchan,</span><br><span style="color: hsl(0, 100%, 40%);">-                                        const struct gsm48_hdr *gh)</span><br><span style="color: hsl(120, 100%, 40%);">+                                           const struct gsm48_meas_res *meas_res)</span><br><span> {</span><br><span style="color: hsl(0, 100%, 40%);">-       const struct gsm48_meas_res *meas_res;</span><br><span>       uint8_t upper;</span><br><span>       uint8_t lower;</span><br><span>       uint8_t rxqual;</span><br><span>@@ -828,14 +827,8 @@</span><br><span>       }</span><br><span> </span><br><span>        /* Parse MS measurement results */</span><br><span style="color: hsl(0, 100%, 40%);">-      if (gh == NULL)</span><br><span style="color: hsl(120, 100%, 40%);">+       if (meas_res == NULL)</span><br><span>                goto out;</span><br><span style="color: hsl(0, 100%, 40%);">-       /* Check if this is a Measurement Report */</span><br><span style="color: hsl(0, 100%, 40%);">-     if (gh->proto_discr != GSM48_PDISC_RR)</span><br><span style="color: hsl(0, 100%, 40%);">-               goto out;</span><br><span style="color: hsl(0, 100%, 40%);">-       if (gh->msg_type != GSM48_MT_RR_MEAS_REP)</span><br><span style="color: hsl(0, 100%, 40%);">-            goto out;</span><br><span style="color: hsl(0, 100%, 40%);">-       meas_res = (const struct gsm48_meas_res *) gh->data;</span><br><span>      if (meas_res->meas_valid != 0) /* 0 = valid */</span><br><span>            goto out;</span><br><span> </span><br><span>@@ -967,7 +960,7 @@</span><br><span>  if (gh)</span><br><span>              lchan_bs_pwr_ctrl(lchan, gh);</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-       repeated_dl_facch_active_decision(lchan, gh);</span><br><span style="color: hsl(120, 100%, 40%);">+ repeated_dl_facch_active_decision(lchan, mr);</span><br><span> </span><br><span>    /* Reset state for next iteration */</span><br><span>         lchan->tch.dtx.dl_active = false;</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-bts/+/26048">change 26048</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-bts/+/26048"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-bts </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Idbf5f95d632aa2270c49b351ad5561ca2182bf9a </div>
<div style="display:none"> Gerrit-Change-Number: 26048 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: fixeria <vyanitskiy@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>