<p>dexter has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/pysim/+/26038">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">cards: use python style commends to describe methods<br><br>Change-Id: Iae862d8f0a191c7015a94f9516ef5804265f7a82<br>---<br>M pySim/cards.py<br>1 file changed, 7 insertions(+), 15 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/38/26038/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/pySim/cards.py b/pySim/cards.py</span><br><span>index 95352ff..1a86b14 100644</span><br><span>--- a/pySim/cards.py</span><br><span>+++ b/pySim/cards.py</span><br><span>@@ -74,9 +74,7 @@</span><br><span> return True</span><br><span> </span><br><span> def verify_adm(self, key):</span><br><span style="color: hsl(0, 100%, 40%);">- '''</span><br><span style="color: hsl(0, 100%, 40%);">- Authenticate with ADM key</span><br><span style="color: hsl(0, 100%, 40%);">- '''</span><br><span style="color: hsl(120, 100%, 40%);">+ """Authenticate with ADM key"""</span><br><span> (res, sw) = self._scc.verify_chv(self._adm_chv_num, key)</span><br><span> return sw</span><br><span> </span><br><span>@@ -135,10 +133,7 @@</span><br><span> return (None, sw)</span><br><span> </span><br><span> def update_oplmn_act(self, mcc, mnc, access_tech='FFFF'):</span><br><span style="color: hsl(0, 100%, 40%);">- """</span><br><span style="color: hsl(0, 100%, 40%);">- See note in update_hplmn_act()</span><br><span style="color: hsl(0, 100%, 40%);">- """</span><br><span style="color: hsl(0, 100%, 40%);">- # get size and write EF.OPLMNwAcT</span><br><span style="color: hsl(120, 100%, 40%);">+ """get size and write EF.OPLMNwAcT, See note in update_hplmn_act()"""</span><br><span> data = self._scc.read_binary(EF['OPLMNwAcT'], length=None, offset=0)</span><br><span> size = len(data[0]) // 2</span><br><span> hplmn = enc_plmn(mcc, mnc)</span><br><span>@@ -154,10 +149,7 @@</span><br><span> return (None, sw)</span><br><span> </span><br><span> def update_plmn_act(self, mcc, mnc, access_tech='FFFF'):</span><br><span style="color: hsl(0, 100%, 40%);">- """</span><br><span style="color: hsl(0, 100%, 40%);">- See note in update_hplmn_act()</span><br><span style="color: hsl(0, 100%, 40%);">- """</span><br><span style="color: hsl(0, 100%, 40%);">- # get size and write EF.PLMNwAcT</span><br><span style="color: hsl(120, 100%, 40%);">+ """get size and write EF.PLMNwAcT, See note in update_hplmn_act()"""</span><br><span> data = self._scc.read_binary(EF['PLMNwAcT'], length=None, offset=0)</span><br><span> size = len(data[0]) // 2</span><br><span> hplmn = enc_plmn(mcc, mnc)</span><br><span>@@ -265,8 +257,8 @@</span><br><span> else:</span><br><span> return (None, sw)</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- # Fetch all the AIDs present on UICC</span><br><span> def read_aids(self):</span><br><span style="color: hsl(120, 100%, 40%);">+ """Fetch all the AIDs present on UICC"""</span><br><span> self._aids = []</span><br><span> try:</span><br><span> # Find out how many records the EF.DIR has</span><br><span>@@ -282,8 +274,8 @@</span><br><span> self._aids = []</span><br><span> return self._aids</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- # Select ADF.U/ISIM in the Card using its full AID</span><br><span> def select_adf_by_aid(self, adf="usim"):</span><br><span style="color: hsl(120, 100%, 40%);">+ """Select ADF.U/ISIM in the Card using its full AID"""</span><br><span> # Find full AID by partial AID:</span><br><span> if is_hex(adf):</span><br><span> for aid in self._aids:</span><br><span>@@ -300,13 +292,13 @@</span><br><span> return self._scc.select_adf(aid)</span><br><span> return (None, None)</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- # Erase the contents of a file</span><br><span> def erase_binary(self, ef):</span><br><span style="color: hsl(120, 100%, 40%);">+ """Erase the contents of a file"""</span><br><span> len = self._scc.binary_size(ef)</span><br><span> self._scc.update_binary(ef, "ff" * len, offset=0, verify=True)</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- # Erase the contents of a single record</span><br><span> def erase_record(self, ef, rec_no):</span><br><span style="color: hsl(120, 100%, 40%);">+ """Erase the contents of a single record"""</span><br><span> len = self._scc.record_size(ef)</span><br><span> self._scc.update_record(ef, rec_no, "ff" * len, force_len=False, verify=True)</span><br><span> </span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/pysim/+/26038">change 26038</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/pysim/+/26038"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: pysim </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Iae862d8f0a191c7015a94f9516ef5804265f7a82 </div>
<div style="display:none"> Gerrit-Change-Number: 26038 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: dexter <pmaier@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>