<p>fixeria has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26005">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">library/MNCC_EncDec.cc: fix encoding of optional 'sdp' field<br><br>Decoding was implemented in [1], but encoding was not.<br><br>Change-Id: I82f8afd3e64d83d165a7070a1b82a6276ef0b020<br>Fixes: [1] Ic9568c8927507e161aadfad1a4d20aa896d8ae30<br>---<br>M library/MNCC_EncDec.cc<br>1 file changed, 4 insertions(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/05/26005/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/library/MNCC_EncDec.cc b/library/MNCC_EncDec.cc</span><br><span>index 7d09d0a..f896cd3 100644</span><br><span>--- a/library/MNCC_EncDec.cc</span><br><span>+++ b/library/MNCC_EncDec.cc</span><br><span>@@ -184,6 +184,10 @@</span><br><span>          strncpy(mncc.imsi, in_sig.imsi(), sizeof(mncc.imsi));</span><br><span>                mncc.lchan_type = in_sig.lchan__type();</span><br><span>              mncc.lchan_mode = in_sig.lchan__mode();</span><br><span style="color: hsl(120, 100%, 40%);">+               if (in_sig.sdp().is_value()) {</span><br><span style="color: hsl(120, 100%, 40%);">+                        const CHARSTRING &sdp = in_sig.sdp();</span><br><span style="color: hsl(120, 100%, 40%);">+                     strncpy(&mncc.sdp[0], sdp, sizeof(mncc.sdp));</span><br><span style="color: hsl(120, 100%, 40%);">+             }</span><br><span>            ret_val = OCTETSTRING(sizeof(mncc), (uint8_t *)&mncc);</span><br><span>           }</span><br><span>            break;</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26005">change 26005</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26005"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-ttcn3-hacks </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I82f8afd3e64d83d165a7070a1b82a6276ef0b020 </div>
<div style="display:none"> Gerrit-Change-Number: 26005 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: fixeria <vyanitskiy@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>