<p>fixeria has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmo-bts/+/25987">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">l1sap: move false PTCCH/U detection into PDCH branch<br><br>This check is only relevant for PDCH timeslots.<br><br>Change-Id: I187fef8f3de0b41b502b0b18acfb11c56c5551f0<br>---<br>M src/common/l1sap.c<br>1 file changed, 8 insertions(+), 9 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/87/25987/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/common/l1sap.c b/src/common/l1sap.c</span><br><span>index 6eb08ba..d9e27b2 100644</span><br><span>--- a/src/common/l1sap.c</span><br><span>+++ b/src/common/l1sap.c</span><br><span>@@ -1494,15 +1494,6 @@</span><br><span> DEBUGPGT(DL1P, &g_time, "Rx PH-DATA.ind chan_nr=%s link_id=0x%02x len=%d\n",</span><br><span> rsl_chan_nr_str(chan_nr), link_id, len);</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- /* Actually, there can be no DATA.ind on PTCCH/U (rather RACH.ind instead),</span><br><span style="color: hsl(0, 100%, 40%);">- * but some BTS models with buggy implementation may still be sending them</span><br><span style="color: hsl(0, 100%, 40%);">- * to us. Let's keep this for backwards compatibility. */</span><br><span style="color: hsl(0, 100%, 40%);">- if (L1SAP_IS_CHAN_PDCH(chan_nr) && L1SAP_IS_PTCCH(fn)) {</span><br><span style="color: hsl(0, 100%, 40%);">- LOGPGT(DL1P, LOGL_NOTICE, &g_time, "There can be no DATA.ind on PTCCH/U. "</span><br><span style="color: hsl(0, 100%, 40%);">- "This is probably a bug of the BTS model you're using, please fix!\n");</span><br><span style="color: hsl(0, 100%, 40%);">- return -EINVAL;</span><br><span style="color: hsl(0, 100%, 40%);">- }</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span> /* The ph_data_param contained in the l1sap primitive may contain</span><br><span> * measurement data. If this data is present, forward it for</span><br><span> * processing */</span><br><span>@@ -1525,6 +1516,14 @@</span><br><span> return 1;</span><br><span> }</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+ /* There can be no DATA.ind on PTCCH/U (rather RACH.ind instead), but some</span><br><span style="color: hsl(120, 100%, 40%);">+ * BTS models with buggy implementation may still be sending them to us. */</span><br><span style="color: hsl(120, 100%, 40%);">+ if (L1SAP_IS_PTCCH(fn)) {</span><br><span style="color: hsl(120, 100%, 40%);">+ LOGPGT(DL1P, LOGL_NOTICE, &g_time, "There can be no DATA.ind on PTCCH/U. "</span><br><span style="color: hsl(120, 100%, 40%);">+ "This is probably a bug of the BTS model you're using, please fix!\n");</span><br><span style="color: hsl(120, 100%, 40%);">+ return -EINVAL;</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> /* Drop all data from incomplete UL block */</span><br><span> if (pr_info != PRES_INFO_BOTH)</span><br><span> len = 0;</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-bts/+/25987">change 25987</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-bts/+/25987"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: osmo-bts </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I187fef8f3de0b41b502b0b18acfb11c56c5551f0 </div>
<div style="display:none"> Gerrit-Change-Number: 25987 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: fixeria <vyanitskiy@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>