<p>fixeria has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmo-msc/+/25953">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">libmsc: fix NULL pointer dereference in trans_lcls_compose()<br><br>Change-Id: I96342de4cb3e0bc3d3cac7538d4517aa211e8a38<br>Fixes: CID#240768<br>---<br>M src/libmsc/transaction.c<br>1 file changed, 5 insertions(+), 5 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/53/25953/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/libmsc/transaction.c b/src/libmsc/transaction.c</span><br><span>index 2108ab4..25c0e3c 100644</span><br><span>--- a/src/libmsc/transaction.c</span><br><span>+++ b/src/libmsc/transaction.c</span><br><span>@@ -112,6 +112,11 @@</span><br><span> </span><br><span> struct osmo_lcls *trans_lcls_compose(const struct gsm_trans *trans, bool use_lac)</span><br><span> {</span><br><span style="color: hsl(120, 100%, 40%);">+        if (!trans) {</span><br><span style="color: hsl(120, 100%, 40%);">+         LOGP(DCC, LOGL_ERROR, "LCLS: unable to fill parameters for unallocated transaction\n");</span><br><span style="color: hsl(120, 100%, 40%);">+             return NULL;</span><br><span style="color: hsl(120, 100%, 40%);">+  }</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span>  if (!trans->net->a.sri->sccp)</span><br><span>               return NULL;</span><br><span> </span><br><span>@@ -119,11 +124,6 @@</span><br><span>      struct osmo_lcls *lcls;</span><br><span>      uint8_t w = osmo_ss7_pc_width(&ss7->cfg.pc_fmt);</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-     if (!trans) {</span><br><span style="color: hsl(0, 100%, 40%);">-           LOGP(DCC, LOGL_ERROR, "LCLS: unable to fill parameters for unallocated transaction\n");</span><br><span style="color: hsl(0, 100%, 40%);">-               return NULL;</span><br><span style="color: hsl(0, 100%, 40%);">-    }</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span>    if (!trans->net->lcls_permitted) {</span><br><span>             LOGP(DCC, LOGL_NOTICE, "LCLS disabled globally\n");</span><br><span>                return NULL;</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-msc/+/25953">change 25953</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-msc/+/25953"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-msc </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I96342de4cb3e0bc3d3cac7538d4517aa211e8a38 </div>
<div style="display:none"> Gerrit-Change-Number: 25953 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: fixeria <vyanitskiy@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>