<p>fixeria <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-trx/+/25923">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Jenkins Builder: Verified
  pespin: Looks good to me, but someone else must approve
  osmith: Looks good to me, approved

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">IPCDevice: check value returned from select()<br><br>Change-Id: I1c823317659547bb2391c57ac4d7931de1a383e3<br>Fxies: CID#240744<br>---<br>M Transceiver52M/device/ipc/IPCDevice.cpp<br>1 file changed, 6 insertions(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/Transceiver52M/device/ipc/IPCDevice.cpp b/Transceiver52M/device/ipc/IPCDevice.cpp</span><br><span>index c1c6449..2e40aa3 100644</span><br><span>--- a/Transceiver52M/device/ipc/IPCDevice.cpp</span><br><span>+++ b/Transceiver52M/device/ipc/IPCDevice.cpp</span><br><span>@@ -839,6 +839,7 @@</span><br><span> {</span><br><span>        struct timeval wait = { 0, 100000 };</span><br><span>         fd_set crfds, cwfds;</span><br><span style="color: hsl(120, 100%, 40%);">+  char err_buf[256];</span><br><span>   int max_fd = 0;</span><br><span> </span><br><span>  FD_ZERO(&crfds);</span><br><span>@@ -853,7 +854,11 @@</span><br><span>                  FD_SET(curr_fd->fd, &cwfds);</span><br><span>  }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-   select(max_fd + 1, &crfds, &cwfds, 0, &wait);</span><br><span style="color: hsl(120, 100%, 40%);">+     if (select(max_fd + 1, &crfds, &cwfds, 0, &wait) < 0) {</span><br><span style="color: hsl(120, 100%, 40%);">+                LOGP(DDEV, LOGL_ERROR, "select() failed: %s\n",</span><br><span style="color: hsl(120, 100%, 40%);">+                  strerror_r(errno, err_buf, sizeof(err_buf)));</span><br><span style="color: hsl(120, 100%, 40%);">+            return;</span><br><span style="color: hsl(120, 100%, 40%);">+       }</span><br><span> </span><br><span>        for (unsigned int i = 0; i < chans; i++) {</span><br><span>                int flags = 0;</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-trx/+/25923">change 25923</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-trx/+/25923"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-trx </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I1c823317659547bb2391c57ac4d7931de1a383e3 </div>
<div style="display:none"> Gerrit-Change-Number: 25923 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: fixeria <vyanitskiy@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Hoernchen <ewild@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: osmith <osmith@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>