<p>pespin <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-bts/+/25943">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Jenkins Builder: Verified
  osmith: Looks good to me, but someone else must approve
  pespin: Looks good to me, approved

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">Revert "bts-trx: sched: tx_pdtch_fn: Handle PCU idle blocks properly"<br><br>This reverts commit 8a85b71167c4580ddf9e6c59ea602475fd462b3a.<br><br>This is actually the wrong fix. Proper fix comes as a follow-up patch,<br>since the root cause happens earlier in upper layers. No msg with<br>l2h=NULL should reach this point of code ever.<br><br>Change-Id: Ie23d94924f824bd7e89437ccf73b260f542477c6<br>---<br>M src/osmo-bts-trx/sched_lchan_pdtch.c<br>1 file changed, 2 insertions(+), 5 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/osmo-bts-trx/sched_lchan_pdtch.c b/src/osmo-bts-trx/sched_lchan_pdtch.c</span><br><span>index e9e1e82..4c63acb 100644</span><br><span>--- a/src/osmo-bts-trx/sched_lchan_pdtch.c</span><br><span>+++ b/src/osmo-bts-trx/sched_lchan_pdtch.c</span><br><span>@@ -32,7 +32,6 @@</span><br><span> #include <osmo-bts/logging.h></span><br><span> #include <osmo-bts/scheduler.h></span><br><span> #include <osmo-bts/scheduler_backend.h></span><br><span style="color: hsl(0, 100%, 40%);">-#include <osmo-bts/bts_trx.h></span><br><span> </span><br><span> #include <sched_utils.h></span><br><span> </span><br><span>@@ -162,10 +161,8 @@</span><br><span> </span><br><span>       /* get mac block from queue */</span><br><span>       msg = _sched_dequeue_prim(l1ts, br);</span><br><span style="color: hsl(0, 100%, 40%);">-    if (!msg  || !msg->l2h) {</span><br><span style="color: hsl(0, 100%, 40%);">-            const struct gsm_bts_trx *trx = l1ts->ts->trx;</span><br><span style="color: hsl(0, 100%, 40%);">-            if (!msg  || trx == trx->bts->c0)</span><br><span style="color: hsl(0, 100%, 40%);">-                 LOGL1SB(DL1P, LOGL_INFO, l1ts, br, "No prim for transmit.\n");</span><br><span style="color: hsl(120, 100%, 40%);">+      if (!msg) {</span><br><span style="color: hsl(120, 100%, 40%);">+           LOGL1SB(DL1P, LOGL_INFO, l1ts, br, "No prim for transmit.\n");</span><br><span>             goto no_msg;</span><br><span>         }</span><br><span> </span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-bts/+/25943">change 25943</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-bts/+/25943"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-bts </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Ie23d94924f824bd7e89437ccf73b260f542477c6 </div>
<div style="display:none"> Gerrit-Change-Number: 25943 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: osmith <osmith@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>