<p>pespin has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmo-bts/+/25942">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">bts-trx: sched: tx_pdtch_fn: Handle PCU idle blocks properly<br><br>PCU idle blocks are identified by being 0 length, and hence msg->l2h<br>being null. Don't try to encode those, but simply discard them silently.<br><br>In case there's a missing block in C0, we want to log the event since<br>the BTS is expected to send something on C0.<br><br>Change-Id: I57e215fedeb415db4e67fdc56bf0f1410b5f7130<br>---<br>M src/osmo-bts-trx/sched_lchan_pdtch.c<br>1 file changed, 5 insertions(+), 2 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/42/25942/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/osmo-bts-trx/sched_lchan_pdtch.c b/src/osmo-bts-trx/sched_lchan_pdtch.c</span><br><span>index 4c63acb..e9e1e82 100644</span><br><span>--- a/src/osmo-bts-trx/sched_lchan_pdtch.c</span><br><span>+++ b/src/osmo-bts-trx/sched_lchan_pdtch.c</span><br><span>@@ -32,6 +32,7 @@</span><br><span> #include <osmo-bts/logging.h></span><br><span> #include <osmo-bts/scheduler.h></span><br><span> #include <osmo-bts/scheduler_backend.h></span><br><span style="color: hsl(120, 100%, 40%);">+#include <osmo-bts/bts_trx.h></span><br><span> </span><br><span> #include <sched_utils.h></span><br><span> </span><br><span>@@ -161,8 +162,10 @@</span><br><span> </span><br><span>         /* get mac block from queue */</span><br><span>       msg = _sched_dequeue_prim(l1ts, br);</span><br><span style="color: hsl(0, 100%, 40%);">-    if (!msg) {</span><br><span style="color: hsl(0, 100%, 40%);">-             LOGL1SB(DL1P, LOGL_INFO, l1ts, br, "No prim for transmit.\n");</span><br><span style="color: hsl(120, 100%, 40%);">+      if (!msg  || !msg->l2h) {</span><br><span style="color: hsl(120, 100%, 40%);">+          const struct gsm_bts_trx *trx = l1ts->ts->trx;</span><br><span style="color: hsl(120, 100%, 40%);">+          if (!msg  || trx == trx->bts->c0)</span><br><span style="color: hsl(120, 100%, 40%);">+                       LOGL1SB(DL1P, LOGL_INFO, l1ts, br, "No prim for transmit.\n");</span><br><span>             goto no_msg;</span><br><span>         }</span><br><span> </span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-bts/+/25942">change 25942</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-bts/+/25942"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-bts </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I57e215fedeb415db4e67fdc56bf0f1410b5f7130 </div>
<div style="display:none"> Gerrit-Change-Number: 25942 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>