<p>fixeria <strong>uploaded patch set #2</strong> to this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-bts/+/25948">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">l1sap: fix handling of lchan->pending_rel_ind_msg<br><br>After merging the patch [1] fixing handling of the RLL RELease<br>INDication message in lapdm_rll_tx_cb(), ttcn3-bts-test shows<br>several regressions:<br><br>  pass->fail: BTS_Tests.TC_rll_rel_ind_DCCH_0<br>  pass->fail: BTS_Tests.TC_rll_rel_ind_DCCH_3<br>  pass->fail: BTS_Tests.TC_rll_rel_ind_ACCH_0<br>  pass->fail: BTS_Tests.TC_rll_rel_ind_ACCH_3<br>  pass->fail: BTS_Tests_LAPDm.TC_sabm_dm<br><br>[1] I823c9101bcca72d5792e16379b02d3602ffc2726<br>    991020c049c63768e147d49bd2918c2d2e0f6dcb<br><br>The problem is actually *not* in patch [1], but in the older one<br>[2] which we attempted to fix.  While a logical channel is in<br>signalling mode, the lower layers do not produce PRIM_TCH_RTS,<br>and thus the l1sap_tch_rts_ind() is not being called.<br><br>Unlike l1sap_tch_rts_ind(), the l1sap_ph_rts_ind() is being called<br>regardless of the channel mode (signalling vs speech), so let's<br>move handling of lchan->pending_rel_ind_msg there.<br><br>Change-Id: I2c380f9045624f0a0a8f988bb207bc73d8354857<br>Fixes: [2] Ie4f70c75f0137b4bd72d579b3a32575bac2fca3<br>---<br>M src/common/l1sap.c<br>1 file changed, 7 insertions(+), 11 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/48/25948/2</pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-bts/+/25948">change 25948</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-bts/+/25948"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-bts </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I2c380f9045624f0a0a8f988bb207bc73d8354857 </div>
<div style="display:none"> Gerrit-Change-Number: 25948 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: fixeria <vyanitskiy@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: newpatchset </div>