<p>pespin has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmo-bsc/+/25947">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">Set subslots_per_pchan_vamos[GSM_PCHAN_OSMO_DYN] = 0<br><br>VAMOS secondary lchans are to be used specifically when the osmocom dyn<br>TS is set to pchan_is=TCH_{F,H}. Setting secondary subslots for<br>OSMO_DYN TS is not needed since it's only used to initialize the TS, and<br>OSMO DYN already initializes 8 subslots<br>(subslots_per_pchan[GSM_PCHAN_OSMO_DYN]=8). Otherwise, ts_setup_lchans()<br>will try to initialize 8+2 lchans on the TS, which is more than needed<br>and will access out of bounds in the array.<br><br>Related: OS#5278<br>Change-Id: I8727d5b446179c0ebcd8738507efe5a50afaf1e2<br>---<br>M src/osmo-bsc/gsm_data.c<br>1 file changed, 1 insertion(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/47/25947/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/osmo-bsc/gsm_data.c b/src/osmo-bsc/gsm_data.c</span><br><span>index b0e0a68..0134e34 100644</span><br><span>--- a/src/osmo-bsc/gsm_data.c</span><br><span>+++ b/src/osmo-bsc/gsm_data.c</span><br><span>@@ -633,7 +633,7 @@</span><br><span>     [GSM_PCHAN_SDCCH8_SACCH8C] = 0,</span><br><span>      [GSM_PCHAN_CCCH_SDCCH4_CBCH] = 0,</span><br><span>    [GSM_PCHAN_SDCCH8_SACCH8C_CBCH] = 0,</span><br><span style="color: hsl(0, 100%, 40%);">-    [GSM_PCHAN_OSMO_DYN] = 2,</span><br><span style="color: hsl(120, 100%, 40%);">+     [GSM_PCHAN_OSMO_DYN] = 0,</span><br><span>    [GSM_PCHAN_TCH_F_PDCH] = 2,</span><br><span> };</span><br><span> </span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-bsc/+/25947">change 25947</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-bsc/+/25947"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-bsc </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I8727d5b446179c0ebcd8738507efe5a50afaf1e2 </div>
<div style="display:none"> Gerrit-Change-Number: 25947 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>