<p>laforge <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-bts/+/6966">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  laforge: Looks good to me, approved; Verified

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">rsl: fix handling of REL IND in lapdm_rll_tx_cb()<br><br>During the merge of [1] the patch hunk was applied at a slightly<br>wrong location, so the code path has become unreacheable.<br><br>Change-Id: I823c9101bcca72d5792e16379b02d3602ffc2726<br>Fixes: [1] Ie4f70c75f0137b4bd72d579b3a32575bac2fca3<br>---<br>M src/common/rsl.c<br>1 file changed, 9 insertions(+), 9 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/common/rsl.c b/src/common/rsl.c</span><br><span>index a0afc30..e8f9aa0 100644</span><br><span>--- a/src/common/rsl.c</span><br><span>+++ b/src/common/rsl.c</span><br><span>@@ -3569,6 +3569,15 @@</span><br><span>               LOGPLCHAN(lchan, DRSL, LOGL_INFO, "Handing RLL msg %s from LAPDm to MEAS REP\n",</span><br><span>                     rsl_msg_name(rh->msg_type));</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+         rc = handle_ms_meas_report(lchan, (struct gsm48_hdr *)msgb_l3(msg), msgb_l3len(msg));</span><br><span style="color: hsl(120, 100%, 40%);">+         msgb_free(msg);</span><br><span style="color: hsl(120, 100%, 40%);">+               return rc;</span><br><span style="color: hsl(120, 100%, 40%);">+    } else if (rslms_is_gprs_susp_req(msg)) {</span><br><span style="color: hsl(120, 100%, 40%);">+             return handle_gprs_susp_req(msg);</span><br><span style="color: hsl(120, 100%, 40%);">+     } else {</span><br><span style="color: hsl(120, 100%, 40%);">+              LOGPLCHAN(lchan, DRSL, LOGL_INFO, "Fwd RLL msg %s from LAPDm to A-bis\n",</span><br><span style="color: hsl(120, 100%, 40%);">+                     rsl_msg_name(rh->msg_type));</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span>          /* REL_IND handling */</span><br><span>               if (rh->msg_type == RSL_MT_REL_IND &&</span><br><span>                     (lchan->type == GSM_LCHAN_TCH_F || lchan->type == GSM_LCHAN_TCH_H)) {</span><br><span>@@ -3586,15 +3595,6 @@</span><br><span>                         return 0;</span><br><span>            }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-           rc = handle_ms_meas_report(lchan, (struct gsm48_hdr *)msgb_l3(msg), msgb_l3len(msg));</span><br><span style="color: hsl(0, 100%, 40%);">-           msgb_free(msg);</span><br><span style="color: hsl(0, 100%, 40%);">-         return rc;</span><br><span style="color: hsl(0, 100%, 40%);">-      } else if (rslms_is_gprs_susp_req(msg)) {</span><br><span style="color: hsl(0, 100%, 40%);">-               return handle_gprs_susp_req(msg);</span><br><span style="color: hsl(0, 100%, 40%);">-       } else {</span><br><span style="color: hsl(0, 100%, 40%);">-                LOGPLCHAN(lchan, DRSL, LOGL_INFO, "Fwd RLL msg %s from LAPDm to A-bis\n",</span><br><span style="color: hsl(0, 100%, 40%);">-                       rsl_msg_name(rh->msg_type));</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span>            return abis_bts_rsl_sendmsg(msg);</span><br><span>    }</span><br><span> }</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-bts/+/6966">change 6966</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-bts/+/6966"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-bts </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I823c9101bcca72d5792e16379b02d3602ffc2726 </div>
<div style="display:none"> Gerrit-Change-Number: 6966 </div>
<div style="display:none"> Gerrit-PatchSet: 7 </div>
<div style="display:none"> Gerrit-Owner: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>