<p>fixeria has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmo-bts/+/25906">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">lchan: introduce and use lchan_is_tch() helper<br><br>Change-Id: Icd832667cad1189e3e819c88bde837c4260aa252<br>---<br>M include/osmo-bts/lchan.h<br>M src/common/lchan.c<br>M src/common/rsl.c<br>3 files changed, 5 insertions(+), 3 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/06/25906/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/include/osmo-bts/lchan.h b/include/osmo-bts/lchan.h</span><br><span>index a7e9004..57999b1 100644</span><br><span>--- a/include/osmo-bts/lchan.h</span><br><span>+++ b/include/osmo-bts/lchan.h</span><br><span>@@ -365,3 +365,6 @@</span><br><span>            return false;</span><br><span>        }</span><br><span> }</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+#define lchan_is_tch(lchan) \</span><br><span style="color: hsl(120, 100%, 40%);">+       ((lchan)->type == GSM_LCHAN_TCH_F || (lchan)->type == GSM_LCHAN_TCH_H)</span><br><span>diff --git a/src/common/lchan.c b/src/common/lchan.c</span><br><span>index c2b0144..29fd247 100644</span><br><span>--- a/src/common/lchan.c</span><br><span>+++ b/src/common/lchan.c</span><br><span>@@ -67,7 +67,7 @@</span><br><span>        t200_ms_acch[DL_SAPI0] = bts->t200_ms[T200_SACCH_SDCCH] + fn_advance_ms;</span><br><span>  t200_ms_acch[DL_SAPI3] = bts->t200_ms[T200_SACCH_SDCCH] + fn_advance_ms;</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- if (lchan->rep_acch_cap.dl_facch_all && (lchan->type == GSM_LCHAN_TCH_F || lchan->type == GSM_LCHAN_TCH_H)) {</span><br><span style="color: hsl(120, 100%, 40%);">+        if (lchan->rep_acch_cap.dl_facch_all && lchan_is_tch(lchan)) {</span><br><span>            t200_ms_acch[DL_SAPI0] *= 2;</span><br><span>                 t200_ms_acch[DL_SAPI3] *= 2;</span><br><span>         }</span><br><span>diff --git a/src/common/rsl.c b/src/common/rsl.c</span><br><span>index e8f9aa0..a88201e 100644</span><br><span>--- a/src/common/rsl.c</span><br><span>+++ b/src/common/rsl.c</span><br><span>@@ -3579,8 +3579,7 @@</span><br><span>                         rsl_msg_name(rh->msg_type));</span><br><span> </span><br><span>                /* REL_IND handling */</span><br><span style="color: hsl(0, 100%, 40%);">-          if (rh->msg_type == RSL_MT_REL_IND &&</span><br><span style="color: hsl(0, 100%, 40%);">-                        (lchan->type == GSM_LCHAN_TCH_F || lchan->type == GSM_LCHAN_TCH_H)) {</span><br><span style="color: hsl(120, 100%, 40%);">+           if (rh->msg_type == RSL_MT_REL_IND && lchan_is_tch(lchan))</span><br><span>                        LOGPLCHAN(lchan, DRSL, LOGL_INFO,</span><br><span>                              "Scheduling %s to L3 in next associated TCH-RTS.ind\n",</span><br><span>                            rsl_msg_name(rh->msg_type));</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-bts/+/25906">change 25906</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-bts/+/25906"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-bts </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Icd832667cad1189e3e819c88bde837c4260aa252 </div>
<div style="display:none"> Gerrit-Change-Number: 25906 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: fixeria <vyanitskiy@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>