<p>fixeria <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-bts/+/25890">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Jenkins Builder: Verified
  laforge: Looks good to me, but someone else must approve
  pespin: Looks good to me, approved

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">rsl: send NACK if BTS_FEAT_ACCH_REP is not supported<br><br>Change-Id: I7993cf7842ffde561f2bdc50f56516c3a188b2bc<br>Related: SYS#5114<br>---<br>M src/common/rsl.c<br>1 file changed, 13 insertions(+), 4 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/common/rsl.c b/src/common/rsl.c</span><br><span>index d14395b..3cbfff6 100644</span><br><span>--- a/src/common/rsl.c</span><br><span>+++ b/src/common/rsl.c</span><br><span>@@ -1566,7 +1566,7 @@</span><br><span> }</span><br><span> </span><br><span> /* Parse RSL_IE_OSMO_REP_ACCH_CAP */</span><br><span style="color: hsl(0, 100%, 40%);">-static void parse_repeated_acch_capability(struct gsm_lchan *lchan, struct tlv_parsed *tp)</span><br><span style="color: hsl(120, 100%, 40%);">+static int parse_repeated_acch_capability(struct gsm_lchan *lchan, struct tlv_parsed *tp)</span><br><span> {</span><br><span>  /* 3GPP TS 24.008, section 10.5.1.7 defines a Repeated ACCH Capability</span><br><span>        * bit that indicates if REPEATED FACCH/SACCH is supported or not.</span><br><span>@@ -1577,10 +1577,15 @@</span><br><span>         memset(&lchan->repeated_acch_capability, 0, sizeof(lchan->repeated_acch_capability));</span><br><span> </span><br><span>  if (!TLVP_PRES_LEN(tp, RSL_IE_OSMO_REP_ACCH_CAP, sizeof(lchan->repeated_acch_capability)))</span><br><span style="color: hsl(0, 100%, 40%);">-           return;</span><br><span style="color: hsl(120, 100%, 40%);">+               return 0;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+   if (!osmo_bts_has_feature(lchan->ts->trx->bts->features, BTS_FEAT_ACCH_REP))</span><br><span style="color: hsl(120, 100%, 40%);">+              return -RSL_ERR_OPT_IE_ERROR;</span><br><span> </span><br><span>    memcpy(&lchan->repeated_acch_capability, TLVP_VAL(tp, RSL_IE_OSMO_REP_ACCH_CAP),</span><br><span>             sizeof(lchan->repeated_acch_capability));</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ return 0;</span><br><span> }</span><br><span> </span><br><span> /* Parse RSL_IE_OSMO_TOP_ACCH_CAP */</span><br><span>@@ -1912,7 +1917,9 @@</span><br><span>   /* Remember to send an RSL ACK once the lchan is active */</span><br><span>   lchan->rel_act_kind = LCHAN_REL_ACT_RSL;</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- parse_repeated_acch_capability(lchan, &tp);</span><br><span style="color: hsl(120, 100%, 40%);">+       rc = parse_repeated_acch_capability(lchan, &tp);</span><br><span style="color: hsl(120, 100%, 40%);">+  if (rc < 0)</span><br><span style="color: hsl(120, 100%, 40%);">+                return rsl_tx_chan_act_acknack(lchan, -rc);</span><br><span>  rc = parse_temporary_overpower_acch_capability(lchan, &tp);</span><br><span>      if (rc < 0)</span><br><span>               return rsl_tx_chan_act_acknack(lchan, -rc);</span><br><span>@@ -2180,7 +2187,9 @@</span><br><span>  /* 9.3.53 MultiRate Control */</span><br><span>       /* 9.3.54 Supported Codec Types */</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-  parse_repeated_acch_capability(lchan, &tp);</span><br><span style="color: hsl(120, 100%, 40%);">+       rc = parse_repeated_acch_capability(lchan, &tp);</span><br><span style="color: hsl(120, 100%, 40%);">+  if (rc < 0)</span><br><span style="color: hsl(120, 100%, 40%);">+                return rsl_tx_mode_modif_nack(lchan, -rc);</span><br><span>   rc = parse_temporary_overpower_acch_capability(lchan, &tp);</span><br><span>      if (rc < 0)</span><br><span>               return rsl_tx_mode_modif_nack(lchan, -rc);</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-bts/+/25890">change 25890</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-bts/+/25890"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-bts </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I7993cf7842ffde561f2bdc50f56516c3a188b2bc </div>
<div style="display:none"> Gerrit-Change-Number: 25890 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: fixeria <vyanitskiy@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>