<p>fixeria has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmo-bts/+/25897">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">[overpower] rsl: store full content of RSL_IE_OSMO_TEMP_OVP_ACCH_CAP<br><br>Change-Id: I370c8f95fb64eceb60a9dc2eae1412f8a0df0f4e<br>Related: SYS#5319<br>---<br>M include/osmo-bts/lchan.h<br>M src/common/rsl.c<br>M src/common/scheduler.c<br>3 files changed, 8 insertions(+), 9 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/97/25897/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/include/osmo-bts/lchan.h b/include/osmo-bts/lchan.h</span><br><span>index a7e9004..b463b24 100644</span><br><span>--- a/include/osmo-bts/lchan.h</span><br><span>+++ b/include/osmo-bts/lchan.h</span><br><span>@@ -293,8 +293,8 @@</span><br><span>       struct gsm_power_ctrl_params ms_dpc_params;</span><br><span>  struct gsm_power_ctrl_params bs_dpc_params;</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- /* Temporary Overpower for SACCH/FACCH */</span><br><span style="color: hsl(0, 100%, 40%);">-       uint8_t bs_acch_overpower_db;</span><br><span style="color: hsl(120, 100%, 40%);">+ /* Temporary ACCH overpower capabilities */</span><br><span style="color: hsl(120, 100%, 40%);">+   struct abis_rsl_osmo_temp_ovp_acch_cap top_acch_cap;</span><br><span> </span><br><span>     struct msgb *pending_rel_ind_msg;</span><br><span> </span><br><span>diff --git a/src/common/rsl.c b/src/common/rsl.c</span><br><span>index a0afc30..7fc4f3e 100644</span><br><span>--- a/src/common/rsl.c</span><br><span>+++ b/src/common/rsl.c</span><br><span>@@ -1592,18 +1592,17 @@</span><br><span> static int parse_temporary_overpower_acch_capability(struct gsm_lchan *lchan,</span><br><span>                                                     const struct tlv_parsed *tp)</span><br><span> {</span><br><span style="color: hsl(0, 100%, 40%);">-  struct abis_rsl_osmo_temp_ovp_acch_cap *top;</span><br><span style="color: hsl(120, 100%, 40%);">+  memset(&lchan->top_acch_cap, 0, sizeof(lchan->top_acch_cap));</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-     lchan->bs_acch_overpower_db = 0;</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">-     if (!TLVP_PRES_LEN(tp, RSL_IE_OSMO_TEMP_OVP_ACCH_CAP, sizeof(*top)))</span><br><span style="color: hsl(120, 100%, 40%);">+  if (!TLVP_PRES_LEN(tp, RSL_IE_OSMO_TEMP_OVP_ACCH_CAP, sizeof(lchan->top_acch_cap)))</span><br><span>               return 0;</span><br><span> </span><br><span>        if (!osmo_bts_has_feature(lchan->ts->trx->bts->features, BTS_FEAT_ACCH_TEMP_OVP))</span><br><span>                return -RSL_ERR_OPT_IE_ERROR;</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-       top = (struct abis_rsl_osmo_temp_ovp_acch_cap *)TLVP_VAL(tp, RSL_IE_OSMO_TEMP_OVP_ACCH_CAP);</span><br><span style="color: hsl(0, 100%, 40%);">-    lchan->bs_acch_overpower_db = top->overpower_db;</span><br><span style="color: hsl(120, 100%, 40%);">+        memcpy(&lchan->top_acch_cap,</span><br><span style="color: hsl(120, 100%, 40%);">+          TLVP_VAL(tp, RSL_IE_OSMO_TEMP_OVP_ACCH_CAP),</span><br><span style="color: hsl(120, 100%, 40%);">+          sizeof(lchan->top_acch_cap));</span><br><span> </span><br><span>  return 0;</span><br><span> }</span><br><span>diff --git a/src/common/scheduler.c b/src/common/scheduler.c</span><br><span>index 2a729e4..463a5b8 100644</span><br><span>--- a/src/common/scheduler.c</span><br><span>+++ b/src/common/scheduler.c</span><br><span>@@ -1299,7 +1299,7 @@</span><br><span>                          struct trx_dl_burst_req *br)</span><br><span> {</span><br><span>    const struct trx_chan_desc *desc = &trx_chan_desc[br->chan];</span><br><span style="color: hsl(0, 100%, 40%);">-     const uint8_t overpower_db = lchan->bs_acch_overpower_db;</span><br><span style="color: hsl(120, 100%, 40%);">+  const uint8_t overpower_db = lchan->top_acch_cap.overpower_db;</span><br><span> </span><br><span>        /* Current BS power reduction value in dB */</span><br><span>         br->att = lchan->bs_power_ctrl.current;</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-bts/+/25897">change 25897</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-bts/+/25897"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-bts </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I370c8f95fb64eceb60a9dc2eae1412f8a0df0f4e </div>
<div style="display:none"> Gerrit-Change-Number: 25897 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: fixeria <vyanitskiy@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>