<p>pespin has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmo-iuh/+/25886">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">RFC: WIP: Fix compilation warnings<br><br>This seems to solve the compilation warnings we get when including the<br>related headers.<br>This needs to be applied for each of the in-place struct definitions. If<br>I'm correct it's around 20 of them.<br><br>The question is: Are these generated somehow? can we apply the proposed<br>fixed in the ASN1 compiler?<br><br>Change-Id: I36b6dc391af58334ab87986e76a0b63c4c3dfffa<br>---<br>M include/osmocom/hnbap/CriticalityDiagnostics-IE-List.h<br>M src/hnbap/CriticalityDiagnostics-IE-List.c<br>2 files changed, 22 insertions(+), 21 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-iuh refs/changes/86/25886/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/include/osmocom/hnbap/CriticalityDiagnostics-IE-List.h b/include/osmocom/hnbap/CriticalityDiagnostics-IE-List.h</span><br><span>index 3e24ec9..73ac3fd 100644</span><br><span>--- a/include/osmocom/hnbap/CriticalityDiagnostics-IE-List.h</span><br><span>+++ b/include/osmocom/hnbap/CriticalityDiagnostics-IE-List.h</span><br><span>@@ -26,22 +26,24 @@</span><br><span> /* Forward declarations */</span><br><span> struct IE_Extensions;</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+typedef struct CriticalityDiagnostics_IE_List_Member {</span><br><span style="color: hsl(120, 100%, 40%);">+ Criticality_t iECriticality;</span><br><span style="color: hsl(120, 100%, 40%);">+ ProtocolIE_ID_t iE_ID;</span><br><span style="color: hsl(120, 100%, 40%);">+ TypeOfError_t typeOfError;</span><br><span style="color: hsl(120, 100%, 40%);">+ struct IE_Extensions *iE_Extensions /* OPTIONAL */;</span><br><span style="color: hsl(120, 100%, 40%);">+ /*</span><br><span style="color: hsl(120, 100%, 40%);">+ * This type is extensible,</span><br><span style="color: hsl(120, 100%, 40%);">+ * possible extensions are below.</span><br><span style="color: hsl(120, 100%, 40%);">+ */</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ /* Context for parsing across buffer boundaries */</span><br><span style="color: hsl(120, 100%, 40%);">+ asn_struct_ctx_t _asn_ctx;</span><br><span style="color: hsl(120, 100%, 40%);">+} CriticalityDiagnostics_IE_List_Member_t;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> /* CriticalityDiagnostics-IE-List */</span><br><span> typedef struct CriticalityDiagnostics_IE_List {</span><br><span style="color: hsl(0, 100%, 40%);">- A_SEQUENCE_OF(struct Member {</span><br><span style="color: hsl(0, 100%, 40%);">- Criticality_t iECriticality;</span><br><span style="color: hsl(0, 100%, 40%);">- ProtocolIE_ID_t iE_ID;</span><br><span style="color: hsl(0, 100%, 40%);">- TypeOfError_t typeOfError;</span><br><span style="color: hsl(0, 100%, 40%);">- struct IE_Extensions *iE_Extensions /* OPTIONAL */;</span><br><span style="color: hsl(0, 100%, 40%);">- /*</span><br><span style="color: hsl(0, 100%, 40%);">- * This type is extensible,</span><br><span style="color: hsl(0, 100%, 40%);">- * possible extensions are below.</span><br><span style="color: hsl(0, 100%, 40%);">- */</span><br><span style="color: hsl(0, 100%, 40%);">- </span><br><span style="color: hsl(0, 100%, 40%);">- /* Context for parsing across buffer boundaries */</span><br><span style="color: hsl(0, 100%, 40%);">- asn_struct_ctx_t _asn_ctx;</span><br><span style="color: hsl(0, 100%, 40%);">- } ) list;</span><br><span style="color: hsl(0, 100%, 40%);">- </span><br><span style="color: hsl(120, 100%, 40%);">+ A_SEQUENCE_OF(CriticalityDiagnostics_IE_List_Member_t) list;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> /* Context for parsing across buffer boundaries */</span><br><span> asn_struct_ctx_t _asn_ctx;</span><br><span> } CriticalityDiagnostics_IE_List_t;</span><br><span>diff --git a/src/hnbap/CriticalityDiagnostics-IE-List.c b/src/hnbap/CriticalityDiagnostics-IE-List.c</span><br><span>index b3f48e8..30e9a7e 100644</span><br><span>--- a/src/hnbap/CriticalityDiagnostics-IE-List.c</span><br><span>+++ b/src/hnbap/CriticalityDiagnostics-IE-List.c</span><br><span>@@ -13,7 +13,7 @@</span><br><span> 0, 0 /* No PER value map */</span><br><span> };</span><br><span> static asn_TYPE_member_t asn_MBR_Member_2[] = {</span><br><span style="color: hsl(0, 100%, 40%);">- { ATF_NOFLAGS, 0, offsetof(struct Member, iECriticality),</span><br><span style="color: hsl(120, 100%, 40%);">+ { ATF_NOFLAGS, 0, offsetof(CriticalityDiagnostics_IE_List_Member_t, iECriticality),</span><br><span> (ASN_TAG_CLASS_CONTEXT | (0 << 2)),</span><br><span> -1, /* IMPLICIT tag at current level */</span><br><span> &asn_DEF_Criticality,</span><br><span>@@ -22,7 +22,7 @@</span><br><span> 0,</span><br><span> "iECriticality"</span><br><span> },</span><br><span style="color: hsl(0, 100%, 40%);">- { ATF_NOFLAGS, 0, offsetof(struct Member, iE_ID),</span><br><span style="color: hsl(120, 100%, 40%);">+ { ATF_NOFLAGS, 0, offsetof(CriticalityDiagnostics_IE_List_Member_t, iE_ID),</span><br><span> (ASN_TAG_CLASS_CONTEXT | (1 << 2)),</span><br><span> -1, /* IMPLICIT tag at current level */</span><br><span> &asn_DEF_ProtocolIE_ID,</span><br><span>@@ -31,7 +31,7 @@</span><br><span> 0,</span><br><span> "iE-ID"</span><br><span> },</span><br><span style="color: hsl(0, 100%, 40%);">- { ATF_NOFLAGS, 0, offsetof(struct Member, typeOfError),</span><br><span style="color: hsl(120, 100%, 40%);">+ { ATF_NOFLAGS, 0, offsetof(CriticalityDiagnostics_IE_List_Member_t, typeOfError),</span><br><span> (ASN_TAG_CLASS_CONTEXT | (2 << 2)),</span><br><span> -1, /* IMPLICIT tag at current level */</span><br><span> &asn_DEF_TypeOfError,</span><br><span>@@ -40,7 +40,7 @@</span><br><span> 0,</span><br><span> "typeOfError"</span><br><span> },</span><br><span style="color: hsl(0, 100%, 40%);">- { ATF_POINTER, 1, offsetof(struct Member, iE_Extensions),</span><br><span style="color: hsl(120, 100%, 40%);">+ { ATF_POINTER, 1, offsetof(CriticalityDiagnostics_IE_List_Member_t, iE_Extensions),</span><br><span> (ASN_TAG_CLASS_CONTEXT | (3 << 2)),</span><br><span> -1, /* IMPLICIT tag at current level */</span><br><span> &asn_DEF_IE_Extensions,</span><br><span>@@ -61,8 +61,8 @@</span><br><span> { (ASN_TAG_CLASS_CONTEXT | (3 << 2)), 3, 0, 0 } /* iE-Extensions */</span><br><span> };</span><br><span> static asn_SEQUENCE_specifics_t asn_SPC_Member_specs_2 = {</span><br><span style="color: hsl(0, 100%, 40%);">- sizeof(struct Member),</span><br><span style="color: hsl(0, 100%, 40%);">- offsetof(struct Member, _asn_ctx),</span><br><span style="color: hsl(120, 100%, 40%);">+ sizeof(CriticalityDiagnostics_IE_List_Member_t),</span><br><span style="color: hsl(120, 100%, 40%);">+ offsetof(CriticalityDiagnostics_IE_List_Member_t, _asn_ctx),</span><br><span> asn_MAP_Member_tag2el_2,</span><br><span> 4, /* Count of tags in the map */</span><br><span> asn_MAP_Member_oms_2, /* Optional members */</span><br><span>@@ -143,4 +143,3 @@</span><br><span> 1, /* Single element */</span><br><span> &asn_SPC_CriticalityDiagnostics_IE_List_specs_1 /* Additional specs */</span><br><span> };</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-iuh/+/25886">change 25886</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-iuh/+/25886"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: osmo-iuh </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I36b6dc391af58334ab87986e76a0b63c4c3dfffa </div>
<div style="display:none"> Gerrit-Change-Number: 25886 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>