<p>laforge has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/pysim/+/25871">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">pySim-shell: Use iteration when unregistering command sets<br><br>This makes it more easy to extend in the future<br><br>Change-Id: I53ecf03d330fe1eb80ee920e6f9c8185f9be48fd<br>---<br>M pySim-shell.py<br>1 file changed, 4 insertions(+), 6 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/71/25871/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/pySim-shell.py b/pySim-shell.py</span><br><span>index 316ac6f..0de237b 100755</span><br><span>--- a/pySim-shell.py</span><br><span>+++ b/pySim-shell.py</span><br><span>@@ -138,12 +138,10 @@</span><br><span>              # Unequip everything from pySim-shell that would not work in unequipped state</span><br><span>                if self.rs:</span><br><span>                  self.rs.unregister_cmds(self)</span><br><span style="color: hsl(0, 100%, 40%);">-           cmd_set = self.find_commandsets(Iso7816Commands)</span><br><span style="color: hsl(0, 100%, 40%);">-                if cmd_set:</span><br><span style="color: hsl(0, 100%, 40%);">-                     self.unregister_command_set(cmd_set[0])</span><br><span style="color: hsl(0, 100%, 40%);">-         cmd_set = self.find_commandsets(PySimCommands)</span><br><span style="color: hsl(0, 100%, 40%);">-          if cmd_set:</span><br><span style="color: hsl(0, 100%, 40%);">-                     self.unregister_command_set(cmd_set[0])</span><br><span style="color: hsl(120, 100%, 40%);">+               for cmds in [Iso7816Commands, PySimCommands]:</span><br><span style="color: hsl(120, 100%, 40%);">+                 cmd_set = self.find_commandsets(cmds)</span><br><span style="color: hsl(120, 100%, 40%);">+                 if cmd_set:</span><br><span style="color: hsl(120, 100%, 40%);">+                           self.unregister_command_set(cmd_set[0])</span><br><span> </span><br><span>          self.card = card</span><br><span>             self.rs = rs</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/pysim/+/25871">change 25871</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/pysim/+/25871"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: pysim </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I53ecf03d330fe1eb80ee920e6f9c8185f9be48fd </div>
<div style="display:none"> Gerrit-Change-Number: 25871 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>