<p>laforge <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/pysim/+/25801">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  laforge: Looks good to me, approved
  dexter: Looks good to me, but someone else must approve
  osmith: Looks good to me, but someone else must approve
  Jenkins Builder: Verified

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">commands: Fix read_binary() for non-zero offset<br><br>Similar to the fix in Ie1aeaab29701946233ed73db3331039690d695da<br>for update_binary(), read_binary() also contained a bug when treating<br>non-zero offsets.<br><br>Change-Id: Ic5c2f0ad1c1ec9c4e9c97e72895382f7b6fa9470<br>Related: OS#5254<br>---<br>M pySim/commands.py<br>1 file changed, 5 insertions(+), 4 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/pySim/commands.py b/pySim/commands.py</span><br><span>index cd2b5b3..d53cb3e 100644</span><br><span>--- a/pySim/commands.py</span><br><span>+++ b/pySim/commands.py</span><br><span>@@ -141,13 +141,14 @@</span><br><span>          if length is None:</span><br><span>                   length = self.__len(r) - offset</span><br><span>              total_data = ''</span><br><span style="color: hsl(0, 100%, 40%);">-         while offset < length:</span><br><span style="color: hsl(0, 100%, 40%);">-                       chunk_len = min(255, length-offset)</span><br><span style="color: hsl(0, 100%, 40%);">-                     pdu = self.cla_byte + 'b0%04x%02x' % (offset, chunk_len)</span><br><span style="color: hsl(120, 100%, 40%);">+              chunk_offset = 0</span><br><span style="color: hsl(120, 100%, 40%);">+              while chunk_offset < length:</span><br><span style="color: hsl(120, 100%, 40%);">+                       chunk_len = min(255, length-chunk_offset)</span><br><span style="color: hsl(120, 100%, 40%);">+                     pdu = self.cla_byte + 'b0%04x%02x' % (offset + chunk_offset, chunk_len)</span><br><span>                      data,sw = self._tp.send_apdu(pdu)</span><br><span>                    if sw == '9000':</span><br><span>                             total_data += data</span><br><span style="color: hsl(0, 100%, 40%);">-                              offset += chunk_len</span><br><span style="color: hsl(120, 100%, 40%);">+                           chunk_offset += chunk_len</span><br><span>                    else:</span><br><span>                                raise ValueError('Failed to read (offset %d)' % (offset))</span><br><span>            return total_data, sw</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/pysim/+/25801">change 25801</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/pysim/+/25801"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: pysim </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Ic5c2f0ad1c1ec9c4e9c97e72895382f7b6fa9470 </div>
<div style="display:none"> Gerrit-Change-Number: 25801 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: dexter <pmaier@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: osmith <osmith@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>