<p>lynxis lazus <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/libosmocore/+/25774">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  daniel: Looks good to me, approved
  pespin: Looks good to me, but someone else must approve
  Jenkins Builder: Verified

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">ns2: don't forward an invalid RESET PDU to the FSM<br><br>When receiving an invalid RESET (e.g. wrong NSEI or NSVCI) do not<br>forward the PDU to the NSVC fsm. Answer it with correct NSEI & NSVCI,<br>log the PDU, then ignore it.<br><br>Fixes: OS#5258<br>Change-Id: I6e562def9c5a1e4534d42884215272b1e66d26c2<br>---<br>M src/gb/gprs_ns2_vc_fsm.c<br>1 file changed, 2 insertions(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/gb/gprs_ns2_vc_fsm.c b/src/gb/gprs_ns2_vc_fsm.c</span><br><span>index 726fc0c..d28897e 100644</span><br><span>--- a/src/gb/gprs_ns2_vc_fsm.c</span><br><span>+++ b/src/gb/gprs_ns2_vc_fsm.c</span><br><span>@@ -887,6 +887,8 @@</span><br><span>                   /* 48.016 § 7.3.1 send RESET_ACK to wrong NSVCI + ignore */</span><br><span>                         if (nsh->pdu_type == NS_PDUT_RESET) {</span><br><span>                             ns2_tx_reset_ack(nsvc);</span><br><span style="color: hsl(120, 100%, 40%);">+                               LOG_NS_SIGNAL(nsvc, "Rx", nsh->pdu_type, LOGL_ERROR, " with wrong NSVCI (exp: %05u, got %05u). Ignoring PDU.\n", nsvc->nsvci, nsvci);</span><br><span style="color: hsl(120, 100%, 40%);">+                               goto out;</span><br><span>                    } else if (nsh->pdu_type == NS_PDUT_STATUS) {</span><br><span>                             /* this is a PDU received over a NSVC and reports a status for another NSVC */</span><br><span>                               target_nsvc = gprs_ns2_nsvc_by_nsvci(nsvc->nse->nsi,  nsvci);</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/libosmocore/+/25774">change 25774</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/libosmocore/+/25774"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: libosmocore </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I6e562def9c5a1e4534d42884215272b1e66d26c2 </div>
<div style="display:none"> Gerrit-Change-Number: 25774 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: lynxis lazus <lynxis@fe80.eu> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: daniel <dwillmann@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: lynxis lazus <lynxis@fe80.eu> </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-CC: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>