<p>laforge <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/pysim/+/25789">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Jenkins Builder: Verified
  laforge: Looks good to me, approved

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">filsystem: Make NotImplementedError more verbose.<br><br>Before:<br>EXCEPTION of type 'NotImplementedError' occurred with message: ''<br><br>After:<br>EXCEPTION of type 'NotImplementedError' occurred with message: 'EF(EF.SST) encoder not yet implemented. Patches welcome.'<br><br>Change-Id: Ie8a10a8847f7c7c6a3332fb9f78de18c9f7f41d0<br>---<br>M pySim/filesystem.py<br>1 file changed, 6 insertions(+), 6 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/pySim/filesystem.py b/pySim/filesystem.py</span><br><span>index 5cdac56..8edac41 100644</span><br><span>--- a/pySim/filesystem.py</span><br><span>+++ b/pySim/filesystem.py</span><br><span>@@ -551,7 +551,7 @@</span><br><span>         elif self._tlv:</span><br><span>             self._tlv.from_dict(abstract_data)</span><br><span>             return self._tlv.to_tlv()</span><br><span style="color: hsl(0, 100%, 40%);">-        raise NotImplementedError</span><br><span style="color: hsl(120, 100%, 40%);">+        raise NotImplementedError("%s encoder not yet implemented. Patches welcome." % self)</span><br><span> </span><br><span>     def encode_hex(self, abstract_data:dict) -> str:</span><br><span>         """Encode abstract representation into raw (hex string) data.</span><br><span>@@ -577,7 +577,7 @@</span><br><span>         elif self._tlv:</span><br><span>             self._tlv.from_dict(abstract_data)</span><br><span>             return b2h(self._tlv.to_tlv())</span><br><span style="color: hsl(0, 100%, 40%);">-        raise NotImplementedError</span><br><span style="color: hsl(120, 100%, 40%);">+        raise NotImplementedError("%s encoder not yet implemented. Patches welcome." % self)</span><br><span> </span><br><span> </span><br><span> class LinFixedEF(CardEF):</span><br><span>@@ -787,7 +787,7 @@</span><br><span>         elif self._tlv:</span><br><span>             self._tlv.from_dict(abstract_data)</span><br><span>             return b2h(self._tlv.to_tlv())</span><br><span style="color: hsl(0, 100%, 40%);">-        raise NotImplementedError</span><br><span style="color: hsl(120, 100%, 40%);">+        raise NotImplementedError("%s encoder not yet implemented. Patches welcome." % self)</span><br><span> </span><br><span>     def encode_record_bin(self, abstract_data:dict) -> bytearray:</span><br><span>         """Encode abstract representation into raw (binary) data.</span><br><span>@@ -812,7 +812,7 @@</span><br><span>         elif self._tlv:</span><br><span>             self._tlv.from_dict(abstract_data)</span><br><span>             return self._tlv.to_tlv()</span><br><span style="color: hsl(0, 100%, 40%);">-        raise NotImplementedError</span><br><span style="color: hsl(120, 100%, 40%);">+        raise NotImplementedError("%s encoder not yet implemented. Patches welcome." % self)</span><br><span> </span><br><span> class CyclicEF(LinFixedEF):</span><br><span>     """Cyclic EF (Entry File) in the smart card filesystem"""</span><br><span>@@ -920,7 +920,7 @@</span><br><span>         elif self._tlv:</span><br><span>             self._tlv.from_dict(abstract_data)</span><br><span>             return b2h(self._tlv.to_tlv())</span><br><span style="color: hsl(0, 100%, 40%);">-        raise NotImplementedError</span><br><span style="color: hsl(120, 100%, 40%);">+        raise NotImplementedError("%s encoder not yet implemented. Patches welcome." % self)</span><br><span> </span><br><span>     def encode_record_bin(self, abstract_data:dict) -> bytearray:</span><br><span>         """Encode abstract representation into raw (binary) data.</span><br><span>@@ -945,7 +945,7 @@</span><br><span>         elif self._tlv:</span><br><span>             self._tlv.from_dict(abstract_data)</span><br><span>             return self._tlv.to_tlv()</span><br><span style="color: hsl(0, 100%, 40%);">-        raise NotImplementedError</span><br><span style="color: hsl(120, 100%, 40%);">+        raise NotImplementedError("%s encoder not yet implemented. Patches welcome." % self)</span><br><span> </span><br><span>     def _decode_bin(self, raw_bin_data:bytearray):</span><br><span>         chunks = [raw_bin_data[i:i+self.rec_len] for i in range(0, len(raw_bin_data), self.rec_len)]</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/pysim/+/25789">change 25789</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/pysim/+/25789"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: pysim </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Ie8a10a8847f7c7c6a3332fb9f78de18c9f7f41d0 </div>
<div style="display:none"> Gerrit-Change-Number: 25789 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>