<p>pespin has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmo-bts/+/25792">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">lchan: Call lapdm_channel_exit() when state changes to NONE<br><br>Fixes crash when TTCN3 BTS_Tests_LAPDm TC_rr_response_frame_loss<br>runs run after TC_t200_n200.<br><br>The BTS was shutdown after TC_t200_n200 failed (drop oml link), and<br>lchan was moved ACTIVE->NONE without lapdm_channel_exit() being called<br>on it. Hence, on next test (TC_rr_response_frame_loss), when<br>lchan_init_lapdm() was called again, some memory corruption was caused.<br><br>Related: SYS#5262<br>Change-Id: If0ec5f0c7be4d15c8d684d33e15e24d68bd5192e<br>---<br>M src/common/lchan.c<br>1 file changed, 3 insertions(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/92/25792/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/common/lchan.c b/src/common/lchan.c</span><br><span>index 6dd11f7..74a7de0 100644</span><br><span>--- a/src/common/lchan.c</span><br><span>+++ b/src/common/lchan.c</span><br><span>@@ -281,6 +281,9 @@</span><br><span>                                       osmo_tdef_get(abis_T_defs, -15, OSMO_TDEF_US, -1));</span><br><span>              }</span><br><span>            break;</span><br><span style="color: hsl(120, 100%, 40%);">+        case LCHAN_S_NONE:</span><br><span style="color: hsl(120, 100%, 40%);">+            lapdm_channel_exit(&lchan->lapdm_ch);</span><br><span style="color: hsl(120, 100%, 40%);">+          /* fall through */</span><br><span>   default:</span><br><span>             if (lchan->early_rr_ia) {</span><br><span>                         /* Early Immediate Assignment: Transition to any other</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-bts/+/25792">change 25792</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-bts/+/25792"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-bts </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: If0ec5f0c7be4d15c8d684d33e15e24d68bd5192e </div>
<div style="display:none"> Gerrit-Change-Number: 25792 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>