<p>dexter <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-bsc/+/25760">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Jenkins Builder: Verified
  pespin: Looks good to me, but someone else must approve
  laforge: Looks good to me, approved

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">osmo_bsc_main: remove code dup in bootstrap_bts()<br><br>The function gsm_set_bts_type() already takes care of setting the<br>model->started flag to true. There is no need to do this in<br>bootstrap_bts() again.<br><br>Change-Id: Ia70943d96d466ab506fe368ef178a2ccc7483adc<br>---<br>M src/osmo-bsc/osmo_bsc_main.c<br>1 file changed, 0 insertions(+), 8 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/osmo-bsc/osmo_bsc_main.c b/src/osmo-bsc/osmo_bsc_main.c</span><br><span>index e8a22fe..dfd055f 100644</span><br><span>--- a/src/osmo-bsc/osmo_bsc_main.c</span><br><span>+++ b/src/osmo-bsc/osmo_bsc_main.c</span><br><span>@@ -446,14 +446,6 @@</span><br><span>    if (!bts->model)</span><br><span>          return -EFAULT;</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-     if (bts->model->start && !bts->model->started) {</span><br><span style="color: hsl(0, 100%, 40%);">-            int ret = bts->model->start(bts->network);</span><br><span style="color: hsl(0, 100%, 40%);">-             if (ret < 0)</span><br><span style="color: hsl(0, 100%, 40%);">-                 return ret;</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">-             bts->model->started = true;</span><br><span style="color: hsl(0, 100%, 40%);">-       }</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span>    /* FIXME: What about secondary TRX of a BTS?  What about a BTS that has TRX</span><br><span>   * in different bands? Why is 'band' a parameter of the BTS and not of the TRX? */</span><br><span>   switch (bts->band) {</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-bsc/+/25760">change 25760</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-bsc/+/25760"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-bsc </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Ia70943d96d466ab506fe368ef178a2ccc7483adc </div>
<div style="display:none"> Gerrit-Change-Number: 25760 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: dexter <pmaier@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: dexter <pmaier@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>