<p>pespin <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-pcu/+/25746">View Change</a></p><div style="white-space:pre-wrap">Approvals:
Jenkins Builder: Verified
osmith: Looks good to me, but someone else must approve
fixeria: Looks good to me, but someone else must approve
dexter: Looks good to me, but someone else must approve
pespin: Looks good to me, approved
</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">pdch: Only release ULC entry if rx ul block matches the expected one<br><br>If it doesn't match out expectancies, it means we early return and hence<br>don't push forward / update whatever state was requested upon receival<br>of the UL message for the expected TBF. Hence, we shall not remove the<br>allocated ULC entry: in this scenario we need to keep it so that timeout<br>procedure times out and the tbf applies whatever measures are required,<br>be it retransmission, releasing itself, etc.<br><br>Change-Id: Ia69a7d92c4b5c98ec71a75605c8dc3a755e63a35<br>---<br>M src/pdch.cpp<br>1 file changed, 4 insertions(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/pdch.cpp b/src/pdch.cpp</span><br><span>index 25e7ff5..cfec71e 100644</span><br><span>--- a/src/pdch.cpp</span><br><span>+++ b/src/pdch.cpp</span><br><span>@@ -343,7 +343,6 @@</span><br><span> </span><br><span> LOGPTBF(tbf, LOGL_DEBUG, "FN=%" PRIu32 " Rx Packet Control Ack (reason=%s)\n",</span><br><span> fn, get_value_string(pdch_ulc_tbf_poll_reason_names, reason));</span><br><span style="color: hsl(0, 100%, 40%);">- pdch_ulc_release_fn(ulc, fn);</span><br><span> </span><br><span> switch (reason) {</span><br><span> case PDCH_ULC_POLL_UL_ACK:</span><br><span>@@ -354,6 +353,7 @@</span><br><span> fn, ts_no, bts_current_frame_number(tbf->bts));</span><br><span> return;</span><br><span> }</span><br><span style="color: hsl(120, 100%, 40%);">+ pdch_ulc_release_fn(ulc, fn);</span><br><span> osmo_fsm_inst_dispatch(ul_tbf->ul_ack_fsm.fi, TBF_UL_ACK_EV_RX_CTRL_ACK, NULL);</span><br><span> /* We can free since we only set polling on final UL ACK/NACK */</span><br><span> LOGPTBF(tbf, LOGL_DEBUG, "[UPLINK] END\n");</span><br><span>@@ -368,6 +368,7 @@</span><br><span> return;</span><br><span> }</span><br><span> LOGPTBF(tbf, LOGL_DEBUG, "[DOWNLINK] UPLINK ASSIGNED\n");</span><br><span style="color: hsl(120, 100%, 40%);">+ pdch_ulc_release_fn(ulc, fn);</span><br><span> /* reset N3105 */</span><br><span> tbf->n_reset(N3105);</span><br><span> osmo_fsm_inst_dispatch(tbf->ul_ass_fsm.fi, TBF_UL_ASS_EV_RX_ASS_CTRL_ACK, NULL);</span><br><span>@@ -400,6 +401,7 @@</span><br><span> return;</span><br><span> }</span><br><span> LOGPTBF(tbf, LOGL_DEBUG, "[UPLINK] DOWNLINK ASSIGNED\n");</span><br><span style="color: hsl(120, 100%, 40%);">+ pdch_ulc_release_fn(ulc, fn);</span><br><span> /* reset N3105 */</span><br><span> tbf->n_reset(N3105);</span><br><span> osmo_fsm_inst_dispatch(tbf->dl_ass_fsm.fi, TBF_DL_ASS_EV_RX_ASS_CTRL_ACK, NULL);</span><br><span>@@ -425,6 +427,7 @@</span><br><span> fn, ts_no, bts_current_frame_number(tbf->bts));</span><br><span> return;</span><br><span> }</span><br><span style="color: hsl(120, 100%, 40%);">+ pdch_ulc_release_fn(ulc, fn);</span><br><span> osmo_fsm_inst_dispatch(ms->nacc->fi, NACC_EV_RX_CELL_CHG_CONTINUE_ACK, NULL);</span><br><span> /* Don't assume MS is no longer reachable (hence don't free) after this: TS 44.060</span><br><span> * "When the mobile station receives the PACKET CELL CHANGE ORDER</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-pcu/+/25746">change 25746</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-pcu/+/25746"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: osmo-pcu </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Ia69a7d92c4b5c98ec71a75605c8dc3a755e63a35 </div>
<div style="display:none"> Gerrit-Change-Number: 25746 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: dexter <pmaier@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: osmith <osmith@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>