<p>pespin has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmo-pcu/+/25748">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">pdch: PktResReq: Avoid releasing ULC entry if expecting something else on UL<br><br>Let's only release PDCH ULC entry if it was indeed what we expected.<br>In other case, time it out.<br><br>Move the case in the switch statement to the start to easy function<br>readibility (early return style).<br><br>Change-Id: I3d8749acca8e7859295d73cce556b2083169f726<br>---<br>M src/pdch.cpp<br>1 file changed, 7 insertions(+), 9 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/48/25748/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/pdch.cpp b/src/pdch.cpp</span><br><span>index 807ce45..a64fb85 100644</span><br><span>--- a/src/pdch.cpp</span><br><span>+++ b/src/pdch.cpp</span><br><span>@@ -638,6 +638,13 @@</span><br><span>          }</span><br><span> </span><br><span>                switch (item->type) {</span><br><span style="color: hsl(120, 100%, 40%);">+              case PDCH_ULC_NODE_TBF_USF:</span><br><span style="color: hsl(120, 100%, 40%);">+                   /* Is it actually valid for an MS to send a PKT Res Req during USF? */</span><br><span style="color: hsl(120, 100%, 40%);">+                        ul_tbf = item->tbf_usf.ul_tbf;</span><br><span style="color: hsl(120, 100%, 40%);">+                     LOGPDCH(this, DRLCMAC, LOGL_NOTICE, "FN=%u PKT RESOURCE REQ: "</span><br><span style="color: hsl(120, 100%, 40%);">+                              "Unexpectedly received, waiting USF of %s\n",</span><br><span style="color: hsl(120, 100%, 40%);">+                               fn, tbf_name(item->tbf_usf.ul_tbf));</span><br><span style="color: hsl(120, 100%, 40%);">+                       return; /* Ignore it */</span><br><span>              case PDCH_ULC_NODE_SBA:</span><br><span>                      sba = item->sba.sba;</span><br><span>                      LOGPDCH(this, DRLCMAC, LOGL_DEBUG, "FN=%u PKT RESOURCE REQ: "</span><br><span>@@ -665,7 +672,6 @@</span><br><span>                                LOGPDCH(this, DRLCMAC, LOGL_NOTICE, "FN=%u PKT RESOURCE REQ: "</span><br><span>                                     "Unexpected TLLI 0x%08x received vs exp 0x%08x\n",</span><br><span>                                         fn, tlli, ul_tbf->tlli());</span><br><span style="color: hsl(0, 100%, 40%);">-                           /* let common path expire the poll */</span><br><span>                                goto return_unref;</span><br><span>                   }</span><br><span>                    /* 3GPP TS 44.060 $ 9.3.3.3 */</span><br><span>@@ -675,14 +681,6 @@</span><br><span>                        ul_tbf->n_reset(N3103);</span><br><span>                   pdch_ulc_release_node(ulc, item);</span><br><span>                    break;</span><br><span style="color: hsl(0, 100%, 40%);">-          case PDCH_ULC_NODE_TBF_USF:</span><br><span style="color: hsl(0, 100%, 40%);">-                     /* Is it actually valid for an MS to send a PKT Res Req during USF? */</span><br><span style="color: hsl(0, 100%, 40%);">-                  ul_tbf = item->tbf_usf.ul_tbf;</span><br><span style="color: hsl(0, 100%, 40%);">-                       LOGPDCH(this, DRLCMAC, LOGL_NOTICE, "FN=%u PKT RESOURCE REQ: "</span><br><span style="color: hsl(0, 100%, 40%);">-                                "Unexpectedly received, waiting USF of %s\n",</span><br><span style="color: hsl(0, 100%, 40%);">-                         fn, tbf_name(item->tbf_usf.ul_tbf));</span><br><span style="color: hsl(0, 100%, 40%);">-                 pdch_ulc_release_node(ulc, item);</span><br><span style="color: hsl(0, 100%, 40%);">-                       break;</span><br><span>               default:</span><br><span>                     OSMO_ASSERT(0);</span><br><span>              }</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-pcu/+/25748">change 25748</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-pcu/+/25748"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-pcu </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I3d8749acca8e7859295d73cce556b2083169f726 </div>
<div style="display:none"> Gerrit-Change-Number: 25748 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>