<p>pespin has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmo-pcu/+/25747">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">pdch: Validate poll reason matches in rcv_control_(egprs)_dl_ack_nack()<br><br>If we didn't expect this kind of UL messages according to pdch ULC, then<br>we shouldn't allow going forward and releasing the ULC entry: let it<br>time out instead so that TBF runs whatever appopiate action is needed in<br>this case, be it retransamission, releasing itself, etc.<br><br>Change-Id: I8ab3f5e4f2f802944269453db13a80c9ede67714<br>---<br>M src/pdch.cpp<br>1 file changed, 4 insertions(+), 2 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/47/25747/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/pdch.cpp b/src/pdch.cpp</span><br><span>index cfec71e..807ce45 100644</span><br><span>--- a/src/pdch.cpp</span><br><span>+++ b/src/pdch.cpp</span><br><span>@@ -463,7 +463,8 @@</span><br><span> </span><br><span>         tfi = ack_nack->DOWNLINK_TFI;</span><br><span>     poll = pdch_ulc_get_node(ulc, fn);</span><br><span style="color: hsl(0, 100%, 40%);">-      if (!poll || poll->type != PDCH_ULC_NODE_TBF_POLL) {</span><br><span style="color: hsl(120, 100%, 40%);">+       if (!poll || poll->type != PDCH_ULC_NODE_TBF_POLL ||</span><br><span style="color: hsl(120, 100%, 40%);">+           poll->tbf_poll.reason != PDCH_ULC_POLL_DL_ACK) {</span><br><span>              LOGPDCH(this, DRLCMAC, LOGL_NOTICE, "PACKET DOWNLINK ACK with "</span><br><span>                    "unknown FN=%u TFI=%d (TRX %d TS %d)\n",</span><br><span>                   fn, tfi, trx_no(), ts_no);</span><br><span>@@ -532,7 +533,8 @@</span><br><span> </span><br><span>         tfi = ack_nack->DOWNLINK_TFI;</span><br><span>     poll = pdch_ulc_get_node(ulc, fn);</span><br><span style="color: hsl(0, 100%, 40%);">-      if (!poll || poll->type != PDCH_ULC_NODE_TBF_POLL) {</span><br><span style="color: hsl(120, 100%, 40%);">+       if (!poll || poll->type != PDCH_ULC_NODE_TBF_POLL ||</span><br><span style="color: hsl(120, 100%, 40%);">+           poll->tbf_poll.reason != PDCH_ULC_POLL_DL_ACK) {</span><br><span>              LOGPDCH(this, DRLCMAC, LOGL_NOTICE, "EGPRS PACKET DOWNLINK ACK with "</span><br><span>                      "unknown FN=%u TFI=%d (TRX %d TS %d)\n",</span><br><span>                   fn, tfi, trx_no(), ts_no);</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-pcu/+/25747">change 25747</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-pcu/+/25747"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-pcu </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I8ab3f5e4f2f802944269453db13a80c9ede67714 </div>
<div style="display:none"> Gerrit-Change-Number: 25747 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>