<p>fixeria <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-bsc/+/25720">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Jenkins Builder: Verified
  laforge: Looks good to me, but someone else must approve
  pespin: Looks good to me, approved

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">rsl_lchan_lookup(): fix handling of ABIS_RSL_CHAN_NR_CBITS_OSMO_PDCH<br><br>If an RF Resource Indication message includes interference band(s)<br>for 'pure' PDCH (i.e. not dynamic) timeslot(s), osmo-bsc logs:<br><br>  DRSL DEBUG abis_rsl.c:1515 (bts=0,trx=0) Rx Resource Indication<br>  DRSL ERROR bts_trx.c:236 (bts=0,trx=0) chan_nr 0xc7 cbits 0x18:<br>    (bts=0,trx=0,ts=7,pchan=PDCH,state=UNUSED) is not GSM_PCHAN_OSMO_DYN<br>  DRSL ERROR abis_rsl.c:141 (bts=0,trx=0,ts=7,pchan=PDCH,state=UNUSED)<br>    Abis RSL Rx Resource Indication: mismatching chan_nr=0xc7<br><br>Let's better check if a timeslot is capable of GSM_PCHAN_PDCH,<br>rather than checking if it's GSM_PCHAN_OSMO_DYN.<br><br>Change-Id: I2cac4acd4c5145c5c525c9952fdc754477ce0942<br>Related: SYS#5313<br>---<br>M src/osmo-bsc/bts_trx.c<br>1 file changed, 2 insertions(+), 2 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/osmo-bsc/bts_trx.c b/src/osmo-bsc/bts_trx.c</span><br><span>index 9b90c91..f30c748 100644</span><br><span>--- a/src/osmo-bsc/bts_trx.c</span><br><span>+++ b/src/osmo-bsc/bts_trx.c</span><br><span>@@ -232,9 +232,9 @@</span><br><span>               break;</span><br><span>       case ABIS_RSL_CHAN_NR_CBITS_OSMO_PDCH:</span><br><span>               lch_idx = 0;</span><br><span style="color: hsl(0, 100%, 40%);">-            ok = (ts->pchan_on_init == GSM_PCHAN_OSMO_DYN);</span><br><span style="color: hsl(120, 100%, 40%);">+            ok = ts_is_capable_of_pchan(ts, GSM_PCHAN_PDCH);</span><br><span>             if (!ok)</span><br><span style="color: hsl(0, 100%, 40%);">-                        LOG_TRX(trx, DRSL, LOGL_ERROR, "chan_nr 0x%x cbits 0x%x: %s is not GSM_PCHAN_OSMO_DYN\n",</span><br><span style="color: hsl(120, 100%, 40%);">+                   LOG_TRX(trx, DRSL, LOGL_ERROR, "chan_nr 0x%x cbits 0x%x: %s is not capable of GSM_PCHAN_PDCH\n",</span><br><span>                           chan_nr, cbits, gsm_ts_and_pchan_name(ts));</span><br><span>          break;</span><br><span>       default:</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-bsc/+/25720">change 25720</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-bsc/+/25720"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-bsc </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I2cac4acd4c5145c5c525c9952fdc754477ce0942 </div>
<div style="display:none"> Gerrit-Change-Number: 25720 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: fixeria <vyanitskiy@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>