<p>keith <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-bsc/+/25653">View Change</a></p><div style="white-space:pre-wrap">Approvals:
Jenkins Builder: Verified
laforge: Looks good to me, but someone else must approve
pespin: Looks good to me, approved
</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">Add vty command to manually force MS Uplink Power<br><br>Change-Id: Ie2642299ea696358db5822571f1f722b5e8f76b9<br>---<br>M src/osmo-bsc/bsc_vty.c<br>M tests/osmo-bsc.vty<br>2 files changed, 54 insertions(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/osmo-bsc/bsc_vty.c b/src/osmo-bsc/bsc_vty.c</span><br><span>index bd61555..879ae3f 100644</span><br><span>--- a/src/osmo-bsc/bsc_vty.c</span><br><span>+++ b/src/osmo-bsc/bsc_vty.c</span><br><span>@@ -1892,6 +1892,57 @@</span><br><span> return CMD_SUCCESS;</span><br><span> }</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+DEFUN(lchan_set_mspower, lchan_set_mspower_cmd,</span><br><span style="color: hsl(120, 100%, 40%);">+ "bts <0-255> trx <0-255> timeslot <0-7> sub-slot <0-7> ms-power <0-40> [verify]\n",</span><br><span style="color: hsl(120, 100%, 40%);">+ BTS_NR_TRX_TS_SS_STR2</span><br><span style="color: hsl(120, 100%, 40%);">+ "Manually force MS Uplink Power Level in dBm on the lchan (for testing)\n"</span><br><span style="color: hsl(120, 100%, 40%);">+ "Set transmit power of the MS in dBm\n"</span><br><span style="color: hsl(120, 100%, 40%);">+ "Check requested level against BAND and UE Power Class.\n")</span><br><span style="color: hsl(120, 100%, 40%);">+{</span><br><span style="color: hsl(120, 100%, 40%);">+ struct gsm_bts *bts;</span><br><span style="color: hsl(120, 100%, 40%);">+ struct gsm_bts_trx *trx;</span><br><span style="color: hsl(120, 100%, 40%);">+ struct gsm_bts_trx_ts *ts;</span><br><span style="color: hsl(120, 100%, 40%);">+ struct gsm_lchan *lchan;</span><br><span style="color: hsl(120, 100%, 40%);">+ int bts_nr = atoi(argv[0]);</span><br><span style="color: hsl(120, 100%, 40%);">+ int trx_nr = atoi(argv[1]);</span><br><span style="color: hsl(120, 100%, 40%);">+ int ss_nr = atoi(argv[3]);</span><br><span style="color: hsl(120, 100%, 40%);">+ bool verify = (argc > 5);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ bts = gsm_bts_num(gsmnet_from_vty(vty), bts_nr);</span><br><span style="color: hsl(120, 100%, 40%);">+ if (!bts) {</span><br><span style="color: hsl(120, 100%, 40%);">+ vty_out(vty, "%% No such BTS (%d)%s", bts_nr, VTY_NEWLINE);</span><br><span style="color: hsl(120, 100%, 40%);">+ return CMD_WARNING;</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ trx = gsm_bts_trx_num(bts, trx_nr);</span><br><span style="color: hsl(120, 100%, 40%);">+ if (!trx) {</span><br><span style="color: hsl(120, 100%, 40%);">+ vty_out(vty, "%% No such TRX (%d)%s", trx_nr, VTY_NEWLINE);</span><br><span style="color: hsl(120, 100%, 40%);">+ return CMD_WARNING;</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ ts = vty_get_ts(vty, argv[0], argv[1], argv[2]);</span><br><span style="color: hsl(120, 100%, 40%);">+ if (!ts) {</span><br><span style="color: hsl(120, 100%, 40%);">+ vty_out(vty, "%% No such TS (%d)%s", atoi(argv[2]), VTY_NEWLINE);</span><br><span style="color: hsl(120, 100%, 40%);">+ return CMD_WARNING;</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+ if (ss_nr >= ts->max_primary_lchans) {</span><br><span style="color: hsl(120, 100%, 40%);">+ vty_out(vty, "%% Invalid sub-slot number for this timeslot type%s", VTY_NEWLINE);</span><br><span style="color: hsl(120, 100%, 40%);">+ return CMD_WARNING;</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ lchan = &ts->lchan[ss_nr];</span><br><span style="color: hsl(120, 100%, 40%);">+ if (!lchan->fi)</span><br><span style="color: hsl(120, 100%, 40%);">+ return CMD_WARNING;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ if (verify) {</span><br><span style="color: hsl(120, 100%, 40%);">+ lchan_update_ms_power_ctrl_level(lchan, atoi(argv[4]));</span><br><span style="color: hsl(120, 100%, 40%);">+ return CMD_SUCCESS;</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+ lchan->ms_power = ms_pwr_ctl_lvl(ts->trx->bts->band, atoi(argv[4]));</span><br><span style="color: hsl(120, 100%, 40%);">+ rsl_chan_ms_power_ctrl(lchan);</span><br><span style="color: hsl(120, 100%, 40%);">+ return CMD_SUCCESS;</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> DEFUN(vamos_modify_lchan, vamos_modify_lchan_cmd,</span><br><span> "bts <0-255> trx <0-255> timeslot <0-7> sub-slot <0-7> modify (vamos|non-vamos) " TSC_ARGS_OPT,</span><br><span> BTS_NR_TRX_TS_SS_STR2</span><br><span>@@ -3410,6 +3461,7 @@</span><br><span> install_element(ENABLE_NODE, &lchan_mdcx_cmd);</span><br><span> install_element(ENABLE_NODE, &lchan_set_borken_cmd);</span><br><span> install_element(ENABLE_NODE, &lchan_reassign_cmd);</span><br><span style="color: hsl(120, 100%, 40%);">+ install_element(ENABLE_NODE, &lchan_set_mspower_cmd);</span><br><span> </span><br><span> install_element(ENABLE_NODE, &handover_subscr_conn_cmd);</span><br><span> install_element(ENABLE_NODE, &assignment_subscr_conn_cmd);</span><br><span>diff --git a/tests/osmo-bsc.vty b/tests/osmo-bsc.vty</span><br><span>index 4027502..ace21df 100644</span><br><span>--- a/tests/osmo-bsc.vty</span><br><span>+++ b/tests/osmo-bsc.vty</span><br><span>@@ -12,6 +12,7 @@</span><br><span> modify Manually send Channel Mode Modify (for debugging)</span><br><span> mdcx Modify RTP Connection</span><br><span> reassign-to Trigger Assignment to an unused lchan on the same cell</span><br><span style="color: hsl(120, 100%, 40%);">+ ms-power Manually force MS Uplink Power Level in dBm on the lchan (for testing)</span><br><span> handover Manually trigger handover (for debugging)</span><br><span> assignment Manually trigger assignment (for debugging)</span><br><span> </span><br><span>@@ -79,6 +80,7 @@</span><br><span> modify Manually send Channel Mode Modify (for debugging)</span><br><span> mdcx Modify RTP Connection</span><br><span> reassign-to Trigger Assignment to an unused lchan on the same cell</span><br><span style="color: hsl(120, 100%, 40%);">+ ms-power Manually force MS Uplink Power Level in dBm on the lchan (for testing)</span><br><span> handover Manually trigger handover (for debugging)</span><br><span> assignment Manually trigger assignment (for debugging)</span><br><span> </span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-bsc/+/25653">change 25653</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-bsc/+/25653"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: osmo-bsc </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Ie2642299ea696358db5822571f1f722b5e8f76b9 </div>
<div style="display:none"> Gerrit-Change-Number: 25653 </div>
<div style="display:none"> Gerrit-PatchSet: 9 </div>
<div style="display:none"> Gerrit-Owner: keith <keith@rhizomatica.org> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: keith <keith@rhizomatica.org> </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>