<p>neels <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/25665">View Change</a></p><div style="white-space:pre-wrap">Approvals:
Jenkins Builder: Verified
fixeria: Looks good to me, but someone else must approve
pespin: Looks good to me, approved
</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">bsc: verify TSC in inter-BSC ho (out) RR HO Cmd<br><br>Related: SYS#4895 OS#5244<br>Related: Iae20df4387c3d75752301bd5daeeea7508966393 (osmo-bsc)<br>Change-Id: Icabcedc59d80e812c3d6ba5d6db5e2bb9b319252<br>---<br>M bsc/BSC_Tests.ttcn<br>1 file changed, 14 insertions(+), 2 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/bsc/BSC_Tests.ttcn b/bsc/BSC_Tests.ttcn</span><br><span>index cc387f6..d64ccc0 100644</span><br><span>--- a/bsc/BSC_Tests.ttcn</span><br><span>+++ b/bsc/BSC_Tests.ttcn</span><br><span>@@ -5677,6 +5677,7 @@</span><br><span> var RslChannelNr new_chan_nr := valueof(t_RslChanNr0(1, RSL_CHAN_NR_Bm_ACCH));</span><br><span> f_rslem_register(0, new_chan_nr);</span><br><span> g_chan_nr := new_chan_nr;</span><br><span style="color: hsl(120, 100%, 40%);">+ var uint3_t expect_target_tsc := BTS_TSC[0];</span><br><span> f_sleep(1.0);</span><br><span> </span><br><span> f_create_mgcp_expect(ExpectCriteria:{omit,omit,omit});</span><br><span>@@ -5696,8 +5697,10 @@</span><br><span> </span><br><span> BSSAP.receive(tr_BSSMAP_HandoverRequestAcknowledge(?)) -> value rx_bssap;</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- /* we're sure that the channel activation is done now, verify the encryption parameters in it */</span><br><span style="color: hsl(0, 100%, 40%);">- f_verify_encr_info(f_rslem_get_last_act(RSL_PROC, 0, g_chan_nr));</span><br><span style="color: hsl(120, 100%, 40%);">+ /* we're sure that the channel activation is done now, verify the parameters in it */</span><br><span style="color: hsl(120, 100%, 40%);">+ var RSL_Message chan_act := f_rslem_get_last_act(RSL_PROC, 0, g_chan_nr);</span><br><span style="color: hsl(120, 100%, 40%);">+ f_verify_encr_info(chan_act);</span><br><span style="color: hsl(120, 100%, 40%);">+ f_chan_act_verify_tsc(chan_act, expect_target_tsc);</span><br><span> </span><br><span> ho_command_str := rx_bssap.pdu.bssmap.handoverRequestAck.layer3Information.layer3info;</span><br><span> log("Received L3 Info in HO Request Ack: ", ho_command_str);</span><br><span>@@ -5717,6 +5720,15 @@</span><br><span> }</span><br><span> log("Handover Command chan_nr is", actual_new_chan_nr);</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+ var uint3_t got_tsc := rr_chan_desc_tsc(ho_command.msgs.rrm.handoverCommand.channelDescription2);</span><br><span style="color: hsl(120, 100%, 40%);">+ if (not match(got_tsc, expect_target_tsc)) {</span><br><span style="color: hsl(120, 100%, 40%);">+ setverdict(fail, "RR Handover Command: unexpected TSC in Channel Description: expected ",</span><br><span style="color: hsl(120, 100%, 40%);">+ expect_target_tsc, " got ", got_tsc);</span><br><span style="color: hsl(120, 100%, 40%);">+ mtc.stop;</span><br><span style="color: hsl(120, 100%, 40%);">+ } else {</span><br><span style="color: hsl(120, 100%, 40%);">+ log("handoverCommand: verified TSC = ", got_tsc);</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> /* Now the MSC forwards the RR Handover Command to the other BSC, which</span><br><span> * tells the MS to handover to the new lchan. Here comes the new MS on</span><br><span> * the new lchan with a Handover RACH: */</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/25665">change 25665</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/25665"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: osmo-ttcn3-hacks </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Icabcedc59d80e812c3d6ba5d6db5e2bb9b319252 </div>
<div style="display:none"> Gerrit-Change-Number: 25665 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: neels <nhofmeyr@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: neels <nhofmeyr@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>