<p>neels has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/25662">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">bsc: TC_ho_int: verify TSC in Chan Act<br><br>OS#5244 reports an error in the Training Sequence Code used in the<br>Channel Activation for a handover target channel. Verify the TSC to<br>uncover this bug.<br><br>Related: SYS#4895, OS#5244<br>Related: Iae20df4387c3d75752301bd5daeeea7508966393 (osmo-bsc)<br>Change-Id: I1ed6f068c85b01e5a2d7b5f2651498a1521f89af<br>---<br>M bsc/BSC_Tests.ttcn<br>1 file changed, 8 insertions(+), 2 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/62/25662/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/bsc/BSC_Tests.ttcn b/bsc/BSC_Tests.ttcn</span><br><span>index 9e4ddff..e8bb99c 100644</span><br><span>--- a/bsc/BSC_Tests.ttcn</span><br><span>+++ b/bsc/BSC_Tests.ttcn</span><br><span>@@ -5081,7 +5081,7 @@</span><br><span>            handover_done := false,</span><br><span>              old_chan_nr := -</span><br><span>     };</span><br><span style="color: hsl(0, 100%, 40%);">-      /* issue hand-over command on VTY */</span><br><span style="color: hsl(120, 100%, 40%);">+  /* issue hand-over command on VTY, from BTS 0 to BTS 1 */</span><br><span>    f_vty_handover(BSCVTY, 0, 0, g_chan_nr, 1);</span><br><span>  /* temporarily suspend DChan processing on BTS1 to avoid race with RSLEM_register */</span><br><span>         f_rslem_suspend(RSL1_PROC);</span><br><span>@@ -5103,9 +5103,13 @@</span><br><span>          * test expectation */</span><br><span>       f_check_mgcp_expectations()</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+       var RSL_Message chan_act := f_rslem_get_last_act(RSL1_PROC, 0, g_chan_nr);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span>         /* Ensure the Channel Activation for the new channel contained the right encryption params. as_handover() set</span><br><span>         * g_chan_nr to the new lchan that was handed over to. It lives in bts 1, so look it up at RSL1_PROC. */</span><br><span style="color: hsl(0, 100%, 40%);">-        f_verify_encr_info(f_rslem_get_last_act(RSL1_PROC, 0, g_chan_nr));</span><br><span style="color: hsl(120, 100%, 40%);">+    f_verify_encr_info(chan_act);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+       f_chan_act_verify_tsc(chan_act, BTS_TSC[1]);</span><br><span> </span><br><span>     f_sleep(0.5);</span><br><span> }</span><br><span>@@ -5116,6 +5120,8 @@</span><br><span>   f_init(2, true);</span><br><span>     f_sleep(1.0);</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+     pars.expect_tsc := BTS_TSC[0];</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span>     f_ctrs_bsc_and_bts_init();</span><br><span> </span><br><span>       vc_conn := f_start_handler(refers(f_tc_ho_int), pars);</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/25662">change 25662</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/25662"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-ttcn3-hacks </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I1ed6f068c85b01e5a2d7b5f2651498a1521f89af </div>
<div style="display:none"> Gerrit-Change-Number: 25662 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: neels <nhofmeyr@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>