<p>dexter <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/pysim/+/25548">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Jenkins Builder: Verified
  laforge: Looks good to me, approved

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">card_handler: make reader (sl) operations optional.<br><br>The constructor gets an sl object on initalization. The card handler<br>will then carry out the reader operation wait_for_card().<br><br>In cases where an mechanically automated card reader is used it may<br>be useful to go without those operations and let the caller carry out<br>the appropriate reader operations. So Lets make the sl object<br>optional for the CardHandlerAuto class. If it is not present, simply<br>do not carry out the pre programmed reader operation.<br><br>Change-Id: I0f793aec51751b7c7b87d55b66326cce9970274e<br>Related: SYS#5617<br>---<br>M pySim/card_handler.py<br>1 file changed, 2 insertions(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/pySim/card_handler.py b/pySim/card_handler.py</span><br><span>index ef1b071..385c55e 100644</span><br><span>--- a/pySim/card_handler.py</span><br><span>+++ b/pySim/card_handler.py</span><br><span>@@ -94,7 +94,8 @@</span><br><span>      def get(self, first = False):</span><br><span>                print("Ready for Programming: Transporting card into the reader-bay...")</span><br><span>           self.__exec_cmd(self.cmds['get'])</span><br><span style="color: hsl(0, 100%, 40%);">-               self.sl.connect()</span><br><span style="color: hsl(120, 100%, 40%);">+             if self.sl:</span><br><span style="color: hsl(120, 100%, 40%);">+                   self.sl.connect()</span><br><span> </span><br><span>        def error(self):</span><br><span>             print("Programming failed: Transporting card to the error-bin...")</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/pysim/+/25548">change 25548</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/pysim/+/25548"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: pysim </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I0f793aec51751b7c7b87d55b66326cce9970274e </div>
<div style="display:none"> Gerrit-Change-Number: 25548 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: dexter <pmaier@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: daniel <dwillmann@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: dexter <pmaier@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: osmith <osmith@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>