<p>dexter <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/pysim/+/25550">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Jenkins Builder: Verified
  laforge: Looks good to me, approved
  fixeria: Looks good to me, but someone else must approve

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">pySim-shell: verify_adm: turn error messages into exceptions<br><br>When verify_adm is used with scripts, especially bulk provisioning, then<br>an exception is far more visible and allows us to spot problems with ADM<br>verification quicker.<br><br>Change-Id: I4162b43754efd061b6b9058b7ff8e1fc985e3538<br>Related: SYS#5617<br>---<br>M pySim-shell.py<br>1 file changed, 2 insertions(+), 3 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/pySim-shell.py b/pySim-shell.py</span><br><span>index 06e14f6..6699c6f 100755</span><br><span>--- a/pySim-shell.py</span><br><span>+++ b/pySim-shell.py</span><br><span>@@ -310,13 +310,12 @@</span><br><span>                   if pin_adm:</span><br><span>                          self._cmd.poutput("found ADM-PIN '%s' for ICCID '%s'" % (result, self._cmd.iccid))</span><br><span>                         else:</span><br><span style="color: hsl(0, 100%, 40%);">-                           self._cmd.poutput("cannot find ADM-PIN for ICCID '%s'" % (self._cmd.iccid))</span><br><span style="color: hsl(0, 100%, 40%);">-                           return</span><br><span style="color: hsl(120, 100%, 40%);">+                                raise ValueError("cannot find ADM-PIN for ICCID '%s'" % (self._cmd.iccid))</span><br><span> </span><br><span>             if pin_adm:</span><br><span>                  self._cmd.card.verify_adm(h2b(pin_adm))</span><br><span>              else:</span><br><span style="color: hsl(0, 100%, 40%);">-                   self._cmd.poutput("error: cannot authenticate, no adm-pin!")</span><br><span style="color: hsl(120, 100%, 40%);">+                        raise ValueError("error: cannot authenticate, no adm-pin!")</span><br><span> </span><br><span> @with_default_category('ISO7816 Commands')</span><br><span> class Iso7816Commands(CommandSet):</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/pysim/+/25550">change 25550</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/pysim/+/25550"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: pysim </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I4162b43754efd061b6b9058b7ff8e1fc985e3538 </div>
<div style="display:none"> Gerrit-Change-Number: 25550 </div>
<div style="display:none"> Gerrit-PatchSet: 3 </div>
<div style="display:none"> Gerrit-Owner: dexter <pmaier@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: dexter <pmaier@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-CC: osmith <osmith@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>