<p>pespin <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-bts/+/25651">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  pespin: Looks good to me, approved
  Jenkins Builder: Verified

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">fix handle_ms_meas_report(): properly count measurement reports<br><br>Each RSL MEASurement RESult message contains a Measurement Number<br>IE, which is basically a monolithically increasing number.  We<br>shall not increase this counter if for whatever reason the report<br>has not been sent to the BSC.<br><br>Change-Id: I441adb4b202e94ddee8c0b6777849e36ea644b1d<br>Fixes: Id67259ec9ac4c2c33bd0eef3f64450affbe3fb9f<br>Fixes: OS#5243<br>---<br>M src/common/measurement.c<br>1 file changed, 2 insertions(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/common/measurement.c b/src/common/measurement.c</span><br><span>index 7dc0bf1..87e853e 100644</span><br><span>--- a/src/common/measurement.c</span><br><span>+++ b/src/common/measurement.c</span><br><span>@@ -805,6 +805,8 @@</span><br><span> </span><br><span>    timing_offset = ms_to_valid(lchan) ? ms_to2rsl(lchan, le) : -1;</span><br><span>      rc = rsl_tx_meas_res(lchan, (uint8_t *)gh, len, timing_offset);</span><br><span style="color: hsl(120, 100%, 40%);">+       if (rc == 0) /* Count successful transmissions */</span><br><span style="color: hsl(120, 100%, 40%);">+             lchan->meas.res_nr++;</span><br><span> </span><br><span>         /* Run control loops now that we have all the information: */</span><br><span>        /* 3GPP TS 45.008 sec 4.2: UL L1 SACCH Header contains TA and</span><br><span>@@ -850,7 +852,6 @@</span><br><span>          lchan_bs_pwr_ctrl(lchan, (const struct gsm48_hdr *) gh);</span><br><span> </span><br><span>         /* Reset state for next iteration */</span><br><span style="color: hsl(0, 100%, 40%);">-    lchan->meas.res_nr++;</span><br><span>     lchan->tch.dtx.dl_active = false;</span><br><span>         lchan->meas.flags &= ~LC_UL_M_F_OSMO_EXT_VALID;</span><br><span>       lchan->meas.flags &= ~LC_UL_M_F_L1_VALID;</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-bts/+/25651">change 25651</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-bts/+/25651"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-bts </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I441adb4b202e94ddee8c0b6777849e36ea644b1d </div>
<div style="display:none"> Gerrit-Change-Number: 25651 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: fixeria <vyanitskiy@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>