<p>pespin has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmo-bts/+/25643">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">trx_provision_fsm: Fix TRX!=0 never going back to CLOSED state<br><br>Change-Id: I39bef8b5776cbf1098753865c597b1c99d355bec<br>---<br>M src/osmo-bts-trx/trx_provision_fsm.c<br>1 file changed, 4 insertions(+), 7 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/43/25643/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/osmo-bts-trx/trx_provision_fsm.c b/src/osmo-bts-trx/trx_provision_fsm.c</span><br><span>index 36be76f..cdca852 100644</span><br><span>--- a/src/osmo-bts-trx/trx_provision_fsm.c</span><br><span>+++ b/src/osmo-bts-trx/trx_provision_fsm.c</span><br><span>@@ -560,10 +560,7 @@</span><br><span>                   bts_model_trx_close_cb(pinst->trx, 0);</span><br><span>            } /* else: poweroff in progress, cb will be called upon TRXC RSP */</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-         if (pinst->num == 0)</span><br><span style="color: hsl(0, 100%, 40%);">-                 trx_prov_fsm_state_chg(fi, TRX_PROV_ST_OPEN_WAIT_POWEROFF_CNF);</span><br><span style="color: hsl(0, 100%, 40%);">-         else</span><br><span style="color: hsl(0, 100%, 40%);">-                    trx_prov_fsm_state_chg(fi, TRX_PROV_ST_OPEN_POWEROFF);</span><br><span style="color: hsl(120, 100%, 40%);">+                trx_prov_fsm_state_chg(fi, TRX_PROV_ST_OPEN_WAIT_POWEROFF_CNF);</span><br><span>              break;</span><br><span>       case TRX_PROV_EV_CFG_TS:</span><br><span>             ts_data = (struct trx_prov_ev_cfg_ts_data*)data;</span><br><span>@@ -592,9 +589,10 @@</span><br><span> </span><br><span>                  /* Notify TRX close on all TRX associated with this phy */</span><br><span>                   llist_for_each_entry(pinst, &plink->instances, list) {</span><br><span style="color: hsl(120, 100%, 40%);">+                         l1h = pinst->u.osmotrx.hdl;</span><br><span style="color: hsl(120, 100%, 40%);">+                                trx_prov_fsm_state_chg(l1h->provision_fi, TRX_PROV_ST_CLOSED);</span><br><span>                            bts_model_trx_close_cb(pinst->trx, rc);</span><br><span>                   }</span><br><span style="color: hsl(0, 100%, 40%);">-                       trx_prov_fsm_state_chg(fi, TRX_PROV_ST_CLOSED);</span><br><span>              }</span><br><span>            break;</span><br><span>       default:</span><br><span>@@ -646,8 +644,7 @@</span><br><span>                       X(TRX_PROV_EV_CLOSE) |</span><br><span>                       X(TRX_PROV_EV_CFG_TS),</span><br><span>               .out_state_mask =</span><br><span style="color: hsl(0, 100%, 40%);">-                       X(TRX_PROV_ST_OPEN_WAIT_POWEROFF_CNF) |</span><br><span style="color: hsl(0, 100%, 40%);">-                 X(TRX_PROV_ST_OPEN_POWEROFF),</span><br><span style="color: hsl(120, 100%, 40%);">+                 X(TRX_PROV_ST_OPEN_WAIT_POWEROFF_CNF),</span><br><span>               .name = "OPEN_POWERON",</span><br><span>            .onenter = st_open_poweron_on_enter,</span><br><span>                 .action = st_open_poweron,</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-bts/+/25643">change 25643</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-bts/+/25643"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-bts </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I39bef8b5776cbf1098753865c597b1c99d355bec </div>
<div style="display:none"> Gerrit-Change-Number: 25643 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>