<p>fixeria <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-bts/+/25285">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  laforge: Looks good to me, approved
  pespin: Looks good to me, but someone else must approve
  Jenkins Builder: Verified

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">rsl: parse temporary overpower value RSL CHAN ACT / MODIFY<br><br>The temporary overpower value that is to be used with FACCH and SACCH is<br>transferred using a proprietary RSL IE (RSL_IE_OSMO_TOP_ACCH_CAP). The<br>parsed value is then stored in lchan->bs_acch_overpower_db so that it<br>can be used.<br><br>Change-Id: I426c2510865c4a986c68f2027cc676aaac0d8a4c<br>Related: SYS#5319<br>---<br>M src/common/rsl.c<br>1 file changed, 26 insertions(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/common/rsl.c b/src/common/rsl.c</span><br><span>index e13160e..d50983d 100644</span><br><span>--- a/src/common/rsl.c</span><br><span>+++ b/src/common/rsl.c</span><br><span>@@ -1596,6 +1596,26 @@</span><br><span>         sizeof(lchan->repeated_acch_capability));</span><br><span> }</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+/* Parse RSL_IE_OSMO_TOP_ACCH_CAP */</span><br><span style="color: hsl(120, 100%, 40%);">+static int parse_temporary_overpower_acch_capability(struct gsm_lchan *lchan,</span><br><span style="color: hsl(120, 100%, 40%);">+                                                  const struct tlv_parsed *tp)</span><br><span style="color: hsl(120, 100%, 40%);">+{</span><br><span style="color: hsl(120, 100%, 40%);">+  struct abis_rsl_osmo_temp_ovp_acch_cap *top;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+        lchan->bs_acch_overpower_db = 0;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ if (!TLVP_PRES_LEN(tp, RSL_IE_OSMO_TEMP_OVP_ACCH_CAP, sizeof(*top)))</span><br><span style="color: hsl(120, 100%, 40%);">+          return 0;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+   if (!osmo_bts_has_feature(lchan->ts->trx->bts->features, BTS_FEAT_ACCH_TEMP_OVP))</span><br><span style="color: hsl(120, 100%, 40%);">+         return -RSL_ERR_OPT_IE_ERROR;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+       top = (struct abis_rsl_osmo_temp_ovp_acch_cap *)TLVP_VAL(tp, RSL_IE_OSMO_TEMP_OVP_ACCH_CAP);</span><br><span style="color: hsl(120, 100%, 40%);">+  lchan->bs_acch_overpower_db = top->overpower_db;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+      return 0;</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> /* 8.4.1 CHANnel ACTIVation is received */</span><br><span> static int rsl_rx_chan_activ(struct msgb *msg)</span><br><span> {</span><br><span>@@ -1896,6 +1916,9 @@</span><br><span>  lchan->rel_act_kind = LCHAN_REL_ACT_RSL;</span><br><span> </span><br><span>      parse_repeated_acch_capability(lchan, &tp);</span><br><span style="color: hsl(120, 100%, 40%);">+       rc = parse_temporary_overpower_acch_capability(lchan, &tp);</span><br><span style="color: hsl(120, 100%, 40%);">+       if (rc < 0)</span><br><span style="color: hsl(120, 100%, 40%);">+                return rsl_tx_chan_act_acknack(lchan, -rc);</span><br><span> </span><br><span>      /* actually activate the channel in the BTS */</span><br><span>       rc = l1sap_chan_act(lchan->ts->trx, dch->chan_nr, &tp);</span><br><span>@@ -2220,6 +2243,9 @@</span><br><span>         /* 9.3.54 Supported Codec Types */</span><br><span> </span><br><span>       parse_repeated_acch_capability(lchan, &tp);</span><br><span style="color: hsl(120, 100%, 40%);">+       rc = parse_temporary_overpower_acch_capability(lchan, &tp);</span><br><span style="color: hsl(120, 100%, 40%);">+       if (rc < 0)</span><br><span style="color: hsl(120, 100%, 40%);">+                return rsl_tx_mode_modif_nack(lchan, -rc);</span><br><span> </span><br><span>       l1sap_chan_modify(lchan->ts->trx, dch->chan_nr);</span><br><span> </span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-bts/+/25285">change 25285</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-bts/+/25285"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-bts </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I426c2510865c4a986c68f2027cc676aaac0d8a4c </div>
<div style="display:none"> Gerrit-Change-Number: 25285 </div>
<div style="display:none"> Gerrit-PatchSet: 4 </div>
<div style="display:none"> Gerrit-Owner: dexter <pmaier@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>