<p>pespin has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmo-pcu/+/25631">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">assert if tbf pointer for POLL event is NULL<br><br>The tbf pointer should always point to a valid TBF.<br><br>Change-Id: Ib607a38459802f780826f46c20a1696ec98408fb<br>---<br>M src/pdch.cpp<br>1 file changed, 4 insertions(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/31/25631/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/pdch.cpp b/src/pdch.cpp</span><br><span>index 29e3b20..25e7ff5 100644</span><br><span>--- a/src/pdch.cpp</span><br><span>+++ b/src/pdch.cpp</span><br><span>@@ -314,7 +314,7 @@</span><br><span>        struct pdch_ulc_node *poll;</span><br><span> </span><br><span>      poll = pdch_ulc_get_node(ulc, fn);</span><br><span style="color: hsl(0, 100%, 40%);">-      if (!poll || poll->type != PDCH_ULC_NODE_TBF_POLL || !poll->tbf_poll.poll_tbf) {</span><br><span style="color: hsl(120, 100%, 40%);">+        if (!poll || poll->type != PDCH_ULC_NODE_TBF_POLL) {</span><br><span>              LOGPDCH(this, DRLCMAC, LOGL_NOTICE, "PACKET CONTROL ACK with "</span><br><span>                     "unknown FN=%u TLLI=0x%08x (TRX %d TS %d)\n",</span><br><span>                      fn, tlli, trx_no(), ts_no);</span><br><span>@@ -330,6 +330,7 @@</span><br><span>                            ms_dl_tbf(ms) ? ms_dl_tbf(ms)->state_name() : "None");</span><br><span>          return;</span><br><span>      }</span><br><span style="color: hsl(120, 100%, 40%);">+     OSMO_ASSERT(poll->tbf_poll.poll_tbf);</span><br><span>     tbf = poll->tbf_poll.poll_tbf;</span><br><span>    reason = poll->tbf_poll.reason;</span><br><span> </span><br><span>@@ -465,6 +466,7 @@</span><br><span>                         fn, tfi, trx_no(), ts_no);</span><br><span>           return;</span><br><span>      }</span><br><span style="color: hsl(120, 100%, 40%);">+     OSMO_ASSERT(poll->tbf_poll.poll_tbf);</span><br><span>     tbf = as_dl_tbf(poll->tbf_poll.poll_tbf);</span><br><span>         if (tbf->tfi() != tfi) {</span><br><span>          LOGPTBFDL(tbf, LOGL_NOTICE,</span><br><span>@@ -533,6 +535,7 @@</span><br><span>                    fn, tfi, trx_no(), ts_no);</span><br><span>           return;</span><br><span>      }</span><br><span style="color: hsl(120, 100%, 40%);">+     OSMO_ASSERT(poll->tbf_poll.poll_tbf);</span><br><span>     tbf = as_dl_tbf(poll->tbf_poll.poll_tbf);</span><br><span>         if (tbf->tfi() != tfi) {</span><br><span>          LOGPDCH(this, DRLCMAC, LOGL_NOTICE, "EGPRS PACKET DOWNLINK ACK with "</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-pcu/+/25631">change 25631</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-pcu/+/25631"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-pcu </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Ib607a38459802f780826f46c20a1696ec98408fb </div>
<div style="display:none"> Gerrit-Change-Number: 25631 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>